Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container memory usage #5065

Closed
petervo opened this issue Sep 19, 2016 · 4 comments
Closed

Container memory usage #5065

petervo opened this issue Sep 19, 2016 · 4 comments

Comments

@petervo
Copy link
Contributor

petervo commented Sep 19, 2016

Docker includes cache in it's memory.usage_in_bytes numbers so our graphs can can continue to grow making it look like there is a memory leak when there isn't. Should we subtract the cache from the total numbers? Or should we add a visual representation to clarify what is cache and available to be reclaimed by the system and what is actually in use by the process.

@petervo
Copy link
Contributor Author

petervo commented Sep 19, 2016

Reference issues.

moby/moby#10824
docker-archive/libcontainer#518

@dperpeet
Copy link
Contributor

I think adding a visual representation to clarify the distinction would be good, but in any case the amount of memory used without caching is more important.
Why I don't think we should hide cache info completely: That might suggest that docker isn't using memory, even when it is.

@larskarlitski
Copy link
Contributor

This might still be useful, even though it's an old bug.

@garrett, what do we do on the system page? Do we show cache separately?

@garrett
Copy link
Member

garrett commented Mar 4, 2019

Yes! As of #10282 (2018-10-31), Cockpit:

  1. Doesn't show cache on the overview
  2. Shows cache separately on the details graph, with optimized colors and placement, as to not emphasize cache

Details @ https://cockpit-project.org/blog/cockpit-181.html

I think the new(ish) visualization of RAM helps address this issue (and others), so I'm closing it.

Please reopen if you think I'm wrong. 😉

@garrett garrett closed this as completed Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants