Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InvalidLinkBear/URLHeadBear/URLBear: Protocol relative URLs should be tried with http and https #1827

Open
refeed opened this issue Jun 9, 2017 · 2 comments
Open

InvalidLinkBear/URLHeadBear/URLBear: Protocol relative URLs should be tried with http and https #1827

refeed opened this issue Jun 9, 2017 · 2 comments
Labels
difficulty/medium importance/medium

Comments

@refeed
Copy link
Member

refeed commented Jun 9, 2017

In internet, there's a link that has no http or https on it, that's called protocol relative url. For example "//domain.com/img/logo.png". Currently InvalidLinkBear couldn't detect that link is valid or not. InvalidLinkBear should check that url with http or https protocol to check its validity.

See #691 also..
@refeed refeed mentioned this issue Jun 9, 2017
Closed
7 tasks
@gitmate-bot gitmate-bot mentioned this issue Mar 17, 2018
Open
@jayvdb jayvdb changed the title InvalidLinkBear: Protocol relative URLs should be tried with http and https URLHeadBear: Protocol relative URLs should be tried with http and https Apr 7, 2018
@jayvdb jayvdb changed the title URLHeadBear: Protocol relative URLs should be tried with http and https InvalidLinkBear/URLHeadBear: Protocol relative URLs should be tried with http and https Apr 7, 2018
@jayvdb
Copy link
Member

jayvdb commented Apr 7, 2018

This is relevant to both URLHeadBear and InvalidLinkBear.

@jayvdb jayvdb changed the title InvalidLinkBear/URLHeadBear: Protocol relative URLs should be tried with http and https InvalidLinkBear/URLHeadBear/URLBear: Protocol relative URLs should be tried with http and https Apr 7, 2018
@jayvdb
Copy link
Member

jayvdb commented Apr 7, 2018

And URLBear. Currently it does not match links starting with //.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/medium importance/medium
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jayvdb @Makman2 @gitmate-bot @refeed