ESLintBear: Handle corner case if eslint fails

If eslint fails to run, for example if it gets an invalid config file it
does not know how to handle, earlier the bear would throw a JSON
Decoding error because it wouldn't know how to parse "" (an empty
string). Now this case is handled, and it gracefull doesn't try to
create results in such cases.

Fixes #727

Author: AbdealiLoKo

bears/js/ESLintBear.py

@@ -48,7 +48,7 @@ def generate_config(filename, file):
         return '{"extends": "eslint:recommended"}'
 
     def process_output(self, output, filename, file):
-        if not file:
+        if not file or not output:
             return
 
         output = json.loads(output)

tests/js/ESLintBearTest.py

@@ -38,3 +38,12 @@
     ESLintBear,
     valid_files=(test_good, ''),
     invalid_files=(test_syntax_error, test_bad))
+
+# If there is an invalid config file, the results cannot be found. So, no
+# file gives a result.
+ESLintBearWithUnloadablePluginTest = verify_local_bear(
+    ESLintBear,
+    valid_files=(test_bad, test_good),
+    invalid_files=(),
+    settings={"eslint_config": os.path.join(test_dir,
+                                            "eslintconfig_badplugin.json")})

tests/js/test_files/eslintconfig_badplugin.json

@@ -0,0 +1,14 @@
+{
+    "extends": "eslint:recommended",
+    "plugins": ["invalid_plugin_should_throw_error"],
+    "rules": {
+        "consistent-return": 2,
+        "indent"           : [1, 4],
+        "no-else-return"   : 1,
+        "semi"             : [1, "always"],
+        "space-unary-ops"  : [2, {
+            "words": true,
+            "nonwords": true
+        }]
+    }
+}