Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made file access in SimHitPrinter thread safe #9744

Merged

Conversation

cmsbuild
Copy link
Contributor

Since multiple instances of SimHitPrinter all share the same output
file via a static and those instances can be running on different
threads the file has to be protected by a mutex. In addition,
the creation of the file itself is done in a thread safe way.
Automatically ported from CMSSW_7_5_X #9723 (original by @Dr15Jones).

Since multiple instances of SimHitPrinter all share the same output
file via a static and those instances can be running on different
threads the file has to be protected by a mutex. In addition,
the creation of the file itself is done in a thread safe way.
@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_7_6_X.

Made file access in SimHitPrinter thread safe

It involves the following packages:

SimG4CMS/Muon

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Jun 23, 2015

please test

@civanch
Copy link
Contributor

civanch commented Jun 23, 2015

+1

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests.

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests.

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants