-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made file access in SimHitPrinter thread safe #9723
Made file access in SimHitPrinter thread safe #9723
Conversation
Since multiple instances of SimHitPrinter all share the same output file via a static and those instances can be running on different threads the file has to be protected by a mutex. In addition, the creation of the file itself is done in a thread safe way.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X. Made file access in SimHitPrinter thread safe It involves the following packages: SimG4CMS/Muon @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Made file access in SimHitPrinter thread safe
Since multiple instances of SimHitPrinter all share the same output
file via a static and those instances can be running on different
threads the file has to be protected by a mutex. In addition,
the creation of the file itself is done in a thread safe way.