GenParticlePruner: Added sorting of mother and daughter RefVectors #9709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_5_X. GenParticlePruner: Added sorting of mother and daughter RefVectors It involves the following packages: PhysicsTools/HepMCCandAlgos @cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks. |
|
@monttj, can you please sign this one. Thanks. |
|
@ferencek Could you point me which index ranges I am supposed to look? |
|
For example, particle with idx 9 has 4 daughters between indices 47 and 48, which is clearly impossible. Similar case is particle with idx 11. Next, particles with idx 42 to 48 have their daughter index ranges reversed. Similar problems also exist for mothers, e.g., particles with idx 83, 90, etc. However, the total number of mothers and daughters is kept unchanged, as it should be. |
|
In case it helps, here is a full diff. 3,5c3,5
< 0 | 2212 - p+ | 3 | -1 -1 2 87 | 0 7 | 0.000 29256.000 0.000 | 0.000 0.000 6500.000 0.938 |
< 1 | 2212 - p+ | 3 | -1 -1 3 68 | 0 15 | 0.000 -29256.000 0.000 | 0.000 0.000 -6500.000 0.938 |
< 2 | 21 - g | 3 | 0 0 4 73 | 1 29 | 0.652 7.613 0.166 | 0.643 0.107 659.832 0.000 |
---
> 0 | 2212 - p+ | 3 | -1 -1 2 99 | 0 7 | 0.000 29256.000 0.000 | 0.000 0.000 6500.000 0.938 |
> 1 | 2212 - p+ | 3 | -1 -1 3 100 | 0 15 | 0.000 -29256.000 0.000 | 0.000 0.000 -6500.000 0.938 |
> 2 | 21 - g | 3 | 0 0 4 100 | 1 29 | 0.652 7.613 0.166 | 0.643 0.107 659.832 0.000 |
10c10
< 7 | -6 - tbar | 3 | 4 5 10 69 | 2 8 | 242.396 -1.543 -1.365 | 49.615 -237.264 -541.042 174.839 |
---
> 7 | -6 - tbar | 3 | 4 5 10 89 | 2 8 | 242.396 -1.543 -1.365 | 49.615 -237.264 -541.042 174.839 |
12c12
< 9 | 5 - b | 3 | 6 6 47 48 | 1 4 | 42.323 -3.607 -3.020 | -42.012 -5.124 -779.089 4.800 |
---
> 9 | 5 - b | 3 | 6 6 47 93 | 1 4 | 42.323 -3.607 -3.020 | -42.012 -5.124 -779.089 4.800 |
14c14
< 11 | -5 - bbar | 3 | 7 7 64 66 | 1 5 | 39.588 -2.197 -0.126 | 39.275 -4.962 -175.882 4.800 |
---
> 11 | -5 - bbar | 3 | 7 7 64 86 | 1 5 | 39.588 -2.197 -0.126 | 39.275 -4.962 -175.882 4.800 |
16c16
< 13 | 4 - c | 3 | 8 8 74 78 | 1 5 | 36.547 -1.309 1.184 | 13.797 33.843 -62.707 1.500 |
---
> 13 | 4 - c | 3 | 8 8 74 105 | 1 5 | 36.547 -1.309 1.184 | 13.797 33.843 -62.707 1.500 |
28,29c28,29
< 25 | 21 - g | 2 | 2 2 98 81 | 1 3 | 0.395 5.643 -0.206 | 0.387 -0.081 55.785 -0.000 |
< 26 | 21 - g | 2 | 2 2 98 81 | 1 3 | 0.626 2.658 -0.397 | 0.578 -0.242 4.448 0.000 |
---
> 25 | 21 - g | 2 | 2 2 81 99 | 1 3 | 0.395 5.643 -0.206 | 0.387 -0.081 55.785 -0.000 |
> 26 | 21 - g | 2 | 2 2 81 99 | 1 3 | 0.626 2.658 -0.397 | 0.578 -0.242 4.448 0.000 |
31,51c31,51
< 28 | 21 - g | 2 | 3 3 83 92 | 1 3 | 5.548 -2.150 1.324 | 1.353 5.381 -23.491 0.000 |
< 29 | 21 - g | 2 | 3 3 83 92 | 1 3 | 7.704 -2.483 1.096 | 3.521 6.852 -45.802 0.000 |
< 30 | 21 - g | 2 | 3 3 83 92 | 1 3 | 0.698 -2.400 0.979 | 0.390 0.580 -3.819 0.000 |
< 31 | 21 - g | 2 | 3 3 83 92 | 1 3 | 0.914 -3.613 0.241 | 0.888 0.218 -16.936 -0.000 |
< 32 | 21 - g | 2 | 3 3 83 92 | 1 3 | 2.443 -2.941 0.037 | 2.441 0.089 -23.055 0.000 |
< 33 | 21 - g | 2 | 3 3 83 92 | 1 3 | 0.162 -2.748 -2.010 | -0.069 -0.147 -1.260 0.000 |
< 34 | 21 - g | 2 | 3 3 83 92 | 1 3 | 1.160 -3.091 0.494 | 1.022 0.550 -12.731 0.000 |
< 35 | 21 - g | 2 | 3 3 83 92 | 1 3 | 9.511 -3.227 0.377 | 8.842 3.503 -119.722 -0.000 |
< 36 | 21 - g | 2 | 3 3 83 92 | 1 3 | 3.674 -3.577 0.194 | 3.605 0.709 -65.680 0.000 |
< 37 | 21 - g | 2 | 3 3 83 92 | 1 3 | 2.413 -3.405 0.387 | 2.235 0.910 -36.283 0.000 |
< 38 | 21 - g | 2 | 3 3 83 92 | 1 3 | 0.345 -2.406 -0.730 | 0.257 -0.230 -1.898 -0.000 |
< 39 | 21 - g | 2 | 3 3 83 92 | 1 3 | 5.455 -2.849 -0.734 | 4.052 -3.652 -46.951 0.000 |
< 40 | 21 - g | 2 | 3 3 83 92 | 1 3 | 0.913 -3.298 -2.220 | -0.552 -0.727 -12.337 0.000 |
< 41 | 21 - g | 2 | 3 3 83 92 | 1 3 | 0.789 -2.247 -1.001 | 0.426 -0.664 -3.692 0.000 |
< 42 | 21 - g | 2 | 3 3 93 84 | 1 2 | 5.043 -4.474 1.802 | -1.157 4.909 -221.120 -0.000 |
< 43 | 21 - g | 2 | 3 3 93 84 | 1 2 | 0.213 -4.963 -0.217 | 0.208 -0.046 -15.212 0.000 |
< 44 | 21 - g | 2 | 3 3 93 84 | 1 2 | 5.692 -2.956 2.205 | -3.371 4.587 -54.531 0.000 |
< 45 | 21 - g | 2 | 3 3 93 84 | 1 2 | 0.817 -2.454 2.581 | -0.692 0.434 -4.714 -0.000 |
< 46 | 21 - g | 2 | 3 3 93 84 | 1 2 | 1.130 -2.298 2.166 | -0.634 0.936 -5.571 0.000 |
< 47 | 21 - g | 2 | 9 9 93 84 | 1 2 | 7.520 -3.377 -3.030 | -7.473 -0.840 -109.973 0.000 |
< 48 | 5 - b | 2 | 9 9 93 84 | 1 2 | 32.779 -3.652 -3.020 | -32.535 -3.989 -631.280 4.800 |
---
> 28 | 21 - g | 2 | 3 3 83 100 | 1 3 | 5.548 -2.150 1.324 | 1.353 5.381 -23.491 0.000 |
> 29 | 21 - g | 2 | 3 3 83 100 | 1 3 | 7.704 -2.483 1.096 | 3.521 6.852 -45.802 0.000 |
> 30 | 21 - g | 2 | 3 3 83 100 | 1 3 | 0.698 -2.400 0.979 | 0.390 0.580 -3.819 0.000 |
> 31 | 21 - g | 2 | 3 3 83 100 | 1 3 | 0.914 -3.613 0.241 | 0.888 0.218 -16.936 -0.000 |
> 32 | 21 - g | 2 | 3 3 83 100 | 1 3 | 2.443 -2.941 0.037 | 2.441 0.089 -23.055 0.000 |
> 33 | 21 - g | 2 | 3 3 83 100 | 1 3 | 0.162 -2.748 -2.010 | -0.069 -0.147 -1.260 0.000 |
> 34 | 21 - g | 2 | 3 3 83 100 | 1 3 | 1.160 -3.091 0.494 | 1.022 0.550 -12.731 0.000 |
> 35 | 21 - g | 2 | 3 3 83 100 | 1 3 | 9.511 -3.227 0.377 | 8.842 3.503 -119.722 -0.000 |
> 36 | 21 - g | 2 | 3 3 83 100 | 1 3 | 3.674 -3.577 0.194 | 3.605 0.709 -65.680 0.000 |
> 37 | 21 - g | 2 | 3 3 83 100 | 1 3 | 2.413 -3.405 0.387 | 2.235 0.910 -36.283 0.000 |
> 38 | 21 - g | 2 | 3 3 83 100 | 1 3 | 0.345 -2.406 -0.730 | 0.257 -0.230 -1.898 -0.000 |
> 39 | 21 - g | 2 | 3 3 83 100 | 1 3 | 5.455 -2.849 -0.734 | 4.052 -3.652 -46.951 0.000 |
> 40 | 21 - g | 2 | 3 3 83 100 | 1 3 | 0.913 -3.298 -2.220 | -0.552 -0.727 -12.337 0.000 |
> 41 | 21 - g | 2 | 3 3 83 100 | 1 3 | 0.789 -2.247 -1.001 | 0.426 -0.664 -3.692 0.000 |
> 42 | 21 - g | 2 | 3 3 84 93 | 1 2 | 5.043 -4.474 1.802 | -1.157 4.909 -221.120 -0.000 |
> 43 | 21 - g | 2 | 3 3 84 93 | 1 2 | 0.213 -4.963 -0.217 | 0.208 -0.046 -15.212 0.000 |
> 44 | 21 - g | 2 | 3 3 84 93 | 1 2 | 5.692 -2.956 2.205 | -3.371 4.587 -54.531 0.000 |
> 45 | 21 - g | 2 | 3 3 84 93 | 1 2 | 0.817 -2.454 2.581 | -0.692 0.434 -4.714 -0.000 |
> 46 | 21 - g | 2 | 3 3 84 93 | 1 2 | 1.130 -2.298 2.166 | -0.634 0.936 -5.571 0.000 |
> 47 | 21 - g | 2 | 9 9 84 93 | 1 2 | 7.520 -3.377 -3.030 | -7.473 -0.840 -109.973 0.000 |
> 48 | 5 - b | 2 | 9 9 84 93 | 1 2 | 32.779 -3.652 -3.020 | -32.535 -3.989 -631.280 4.800 |
84,86c84,86
< 81 | 2212 - p+ | 1 | 0 2 -1 -1 | 5 0 | 0.940 2.621 -1.144 | 0.389 -0.856 6.431 0.938 |
< 82 | 2212 - p+ | 1 | 0 2 -1 -1 | 4 0 | 0.745 7.218 1.960 | -0.283 0.689 507.800 0.938 |
< 83 | 2212 - p+ | 1 | 1 2 -1 -1 | 16 0 | 2.661 -2.253 1.203 | 0.956 2.483 -12.525 0.938 |
---
> 81 | 2212 - p+ | 1 | 0 26 -1 -1 | 5 0 | 0.940 2.621 -1.144 | 0.389 -0.856 6.431 0.938 |
> 82 | 2212 - p+ | 1 | 0 27 -1 -1 | 4 0 | 0.745 7.218 1.960 | -0.283 0.689 507.800 0.938 |
> 83 | 2212 - p+ | 1 | 1 41 -1 -1 | 16 0 | 2.661 -2.253 1.203 | 0.956 2.483 -12.525 0.938 |
88,95c88,95
< 85 | 2212 - p+ | 1 | 57 66 -1 -1 | 12 0 | 1.438 -2.459 -0.463 | 1.286 -0.642 -8.347 0.938 |
< 86 | -5114 - Sigma*_bbar+ | 2 | 57 66 96 96 | 12 1 | 13.125 -1.951 -0.035 | 13.117 -0.465 -45.218 5.810 |
< 87 | 2212 - p+ | 1 | 2 1 -1 -1 | 3 0 | 2.586 2.625 -2.491 | -2.057 -1.566 17.750 0.938 |
< 88 | 2212 - p+ | 1 | 67 68 -1 -1 | 4 0 | 0.679 -0.925 -2.926 | -0.664 -0.145 -0.722 0.938 |
< 89 | 2212 - p+ | 1 | 67 68 -1 -1 | 4 0 | 1.068 -1.379 -1.683 | -0.119 -1.062 -1.986 0.938 |
< 90 | 423 - D*0 | 2 | 74 13 97 97 | 2 1 | 12.180 -1.306 0.854 | 7.998 9.186 -20.836 2.007 |
< 91 | 2212 - p+ | 1 | 2 1 -1 -1 | 3 0 | 0.284 -0.112 3.041 | -0.283 0.028 -0.032 0.938 |
< 92 | 2212 - p+ | 1 | 1 2 -1 -1 | 16 0 | 2.752 -3.409 0.136 | 2.726 0.373 -41.554 0.938 |
---
> 85 | 2212 - p+ | 1 | 7 66 -1 -1 | 12 0 | 1.438 -2.459 -0.463 | 1.286 -0.642 -8.347 0.938 |
> 86 | -5114 - Sigma*_bbar+ | 2 | 7 66 96 96 | 12 1 | 13.125 -1.951 -0.035 | 13.117 -0.465 -45.218 5.810 |
> 87 | 2212 - p+ | 1 | 0 2 -1 -1 | 3 0 | 2.586 2.625 -2.491 | -2.057 -1.566 17.750 0.938 |
> 88 | 2212 - p+ | 1 | 1 68 -1 -1 | 4 0 | 0.679 -0.925 -2.926 | -0.664 -0.145 -0.722 0.938 |
> 89 | 2212 - p+ | 1 | 1 68 -1 -1 | 4 0 | 1.068 -1.379 -1.683 | -0.119 -1.062 -1.986 0.938 |
> 90 | 423 - D*0 | 2 | 13 74 97 97 | 2 1 | 12.180 -1.306 0.854 | 7.998 9.186 -20.836 2.007 |
> 91 | 2212 - p+ | 1 | 1 24 -1 -1 | 3 0 | 0.284 -0.112 3.041 | -0.283 0.028 -0.032 0.938 |
> 92 | 2212 - p+ | 1 | 1 41 -1 -1 | 16 0 | 2.752 -3.409 0.136 | 2.726 0.373 -41.554 0.938 |
101,103c101,103
< 98 | 11 - e- | 1 | 0 2 -1 -1 | 5 0 | 0.250 6.714 -2.041 | -0.113 -0.223 102.836 0.001 |
< 99 | -11 - e+ | 1 | 0 2 -1 -1 | 5 0 | 0.089 6.678 -1.952 | -0.033 -0.083 35.422 0.001 |
< 100 | 310 - K_S0 | 1 | 1 2 -1 -1 | 16 0 | 1.585 -2.421 1.353 | 0.342 1.548 -8.857 0.498 |
---
> 98 | 11 - e- | 1 | 0 26 -1 -1 | 5 0 | 0.250 6.714 -2.041 | -0.113 -0.223 102.836 0.001 |
> 99 | -11 - e+ | 1 | 0 26 -1 -1 | 5 0 | 0.089 6.678 -1.952 | -0.033 -0.083 35.422 0.001 |
> 100 | 310 - K_S0 | 1 | 1 41 -1 -1 | 16 0 | 1.585 -2.421 1.353 | 0.342 1.548 -8.857 0.498 | |
|
+1 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
cmsbuild
added a commit
that referenced
this pull request
Jun 25, 2015
…rAndDaughterRefVectors_from-CMSSW_7_4_0 GenParticlePruner: Added sorting of mother and daughter RefVectors
ferencek
deleted the
PrunedGenParticles-SortedMotherAndDaughterRefVectors_from-CMSSW_7_4_0
branch
|
@ferencek, may be the change in GenParticlePruner::getMotherKeys is causing two workflows (533.0 and 534.0) to crash (segmentation fault). Stack trace show these workflows run fine in a release without this change e.g. CMSSW_7_6_X_2015-06-23-1100 |
|
@smuzaffar, I will take a look. Thank you for reporting the problem. |
|
@smuzaffar, the problem should be fixed by #10028. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are examples of ParticleListDrawer printouts before:
and after this fix:
The mother and daughter index ranges are correctly printed out after the fix.