Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an uninitialized value in JetDeltaRValueMapProducer #9693

Conversation

Dr15Jones
Copy link
Contributor

A member data was only set conditionally. This problem was found
by valgrind.

A member data was only set conditionally. This problem was found
by valgrind.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_5_X.

Fix an uninitialized value in JetDeltaRValueMapProducer

It involves the following packages:

CommonTools/RecoAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @abbiendi, @jhgoh, @ahinzmann this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Jun 19, 2015

@cmsbuild please test
.. seems trivial though

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Jun 22, 2015

+1

for #9693 99ef854

@slava77
Copy link
Contributor

slava77 commented Jun 22, 2015

@cmsbuild please test
(it looks like the last build failed for whatever reason)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Jun 27, 2015
…roducer-7_5

Fix an uninitialized value in JetDeltaRValueMapProducer
@davidlange6 davidlange6 merged commit 309632b into cms-sw:CMSSW_7_5_X Jun 27, 2015
@Dr15Jones Dr15Jones deleted the uninitValueJetDeltaRValueMapProducer-7_5 branch August 14, 2015 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants