Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration to multithreading of RPCPointProducer (backport in 74X) #9101

Closed
wants to merge 1 commit into from
Closed

migration to multithreading of RPCPointProducer (backport in 74X) #9101

wants to merge 1 commit into from

Conversation

HuguesBrun
Copy link
Contributor

This PR is the backport in 74X of PR #9100

migrate to multithreading + small code cleaning (make config paramete…
e6ff54d 
…rs const + add override to inherited methods)
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone May 15, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @HuguesBrun (Hugues BRUN) for CMSSW_7_4_X.

migration to multithreading of RPCPointProducer (backport in 74X)

It involves the following packages:

RecoLocalMuon/RPCRecHit

@cmsbuild, @cvuosalo, @nclopezo, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

See comments in #9100 about this not being thread safe.

@Dr15Jones
Copy link
Contributor

-1

@slava77
Copy link
Contributor

slava77 commented May 15, 2015

-1
based on assessment by Chris

@cmsbuild
Copy link
Contributor

+1
Tested at: e6ff54d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9101/4757/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9101/4757/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available orp-pending pending-signatures reconstruction-rejected tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
5 participants
@HuguesBrun @cmsbuild @Dr15Jones @slava77 @davidlange6