Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 2023 and 2024 HI MC GTs in autoCond #47439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update 2023 and 2024 HI MC GTs in autoCond #47439

wants to merge 1 commit into from
+2 −2

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Feb 25, 2025 •
edited
Loading

PR description:

The following GTs are updated in autoCond with what can be considered, as of now, their final versions for the 2023 and 2024 HI MC campaigns.

PR validation:

Tested with workflows 322.0 and 332.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

It will get backported in the relevant cycles

@cmsbuild cmsbuild added this to the CMSSW_15_1_X milestone Feb 25, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 25, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47439/43854

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: AddOn
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa9667/44632/summary.html
COMMIT: 1574891
CMSSW: CMSSW_15_1_X_2025-02-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47439/44632/install.sh to create a dev area with all the needed externals and cmssw changes.

AddOn Tests

----- Begin Fatal Exception 25-Feb-2025 12:35:41 CET-----------------------
An exception of category 'GeometryMismatch' occurred while
   [0] Processing  stream begin Run run: 1 stream: 1
   [1] Prefetching for module GEMPadDigiProducer/'simMuonGEMPadDigis'
   [2] Calling method for EventSetup module GEMGeometryESModule/''
Exception Message:
Size mismatch between geometry (size=1386) and alignments (size=1422)
----- End Fatal Exception -------------------------------------------------

----- Begin Fatal Exception 25-Feb-2025 12:37:22 CET-----------------------
An exception of category 'GeometryMismatch' occurred while
   [0] Processing  stream begin Run run: 1 stream: 3
   [1] Prefetching for module PFElecTkProducer/'uncleanedOnlyPfTrackElec'
   [2] Prefetching for EventSetup module TransientTrackBuilderESProducer/''
   [3] Prefetching for EventSetup module GlobalTrackingGeometryESProducer/''
   [4] Calling method for EventSetup module GEMGeometryESModule/''
Exception Message:
Size mismatch between geometry (size=1386) and alignments (size=1422)
----- End Fatal Exception -------------------------------------------------

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3920300
  • DQMHistoTests: Total failures: 64
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3920216
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

@mmusich @Martin-Grunewald about the errors in the hlt_hi_mc addOn tests: I suspect that the origin could be using a 2023 GT with a 2024 scenario, see Configuration/HLT/python/autoCondHLT.py#L41.

What about replacing 'phase1_2023_realistic_hi' with 'phase1_2024_realistic_hi' in that line? I can also do it in this PR, if you think so. (In the meanwhile I am going to run some test with it...)

@mmusich
Copy link
Contributor

mmusich commented Feb 25, 2025

I suspect that the origin could be using a 2023 GT with a 2024 scenario, see Configuration/HLT/python/autoCondHLT.py#L41.

we're planning to update that in any case in the next PR from STORM (commit 0be8752)

@perrotta
Copy link
Contributor Author

I suspect that the origin could be using a 2023 GT with a 2024 scenario, see Configuration/HLT/python/autoCondHLT.py#L41.

we're planning to update that in any case in the next PR from STORM (commit 0be8752)

Ok, thank you Marco.
If your PR is coming, I can wait for it and test this together with your own, once ready.
Otherwise, I will apply the same update in this PR,

@mmusich
Copy link
Contributor

mmusich commented Feb 25, 2025

If your PR is coming, I can wait for it and test this together with your own, once ready.

the PR is coming, but I think we'll do that just before moving the combined table to 15_0_X (and there is still a couple of tickets that could enter in the current 14_2_X table), so it might take a few days.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47439/43869

@cmsbuild
Copy link
Contributor

Pull request #47439 was updated. @Martin-Grunewald, @atpathak, @cmsbuild, @consuegs, @mmusich, @perrotta can you please check and sign again.

@cmsbuild cmsbuild mentioned this pull request Feb 26, 2025
Open
@mmusich
Copy link
Contributor

mmusich commented Feb 26, 2025

#47457 will deliver the desired change: be6f216

As for the changes proposed here:

$ conddb diff 141X_mcRun3_2023_realistic_HI_v5 141X_mcRun3_2023_realistic_HI_v9 | grep GEM
[2025-02-26 13:36:42,451] INFO: Connecting to pro [frontier://PromptProd/cms_conditions]
GEMAlignmentErrorExtendedRcd    -               GEMAlignmentErrorExtended_6x6_MC_v1                                    GEMAlignmentErrorExtendedRcd_mc2024_v1                                
GEMAlignmentRcd                 -               GEMAl_2023_design_v1                                                   GEMAlignment_mc2024_v1

do we know if there are more GEM chambers in the 2024 setup? It looks this update is proposing a tag with "2024" in the name for a 2023 GT. @cms-sw/gem-dpg-l2

@perrotta perrotta force-pushed the updateHiMcGtInAutoCond branch from e26fb3a to 194d280 Compare February 26, 2025 14:19
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47439/43887

@cmsbuild
Copy link
Contributor

Pull request #47439 was updated. @atpathak, @cmsbuild, @consuegs, @perrotta can you please check and sign again.

@perrotta
Copy link
Contributor Author

test parameters:

  • workflow = 322.0,332.0

@perrotta perrotta force-pushed the updateHiMcGtInAutoCond branch from 194d280 to e352dff Compare February 26, 2025 14:25
@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47439/43888

@cmsbuild
Copy link
Contributor

Pull request #47439 was updated. @atpathak, @consuegs, @perrotta can you please check and sign again.

@perrotta
Copy link
Contributor Author

please test

@perrotta
Copy link
Contributor Author

do we know if there are more GEM chambers in the 2024 setup? It looks this update is proposing a tag with "2024" in the name for a 2023 GT.

Thank you @mmusich , good catch.
GEM alignment was updated in _v10 with the correct 2023 settings, also in accordance with the muon alignment group

@perrotta perrotta mentioned this pull request Feb 26, 2025
Open
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa9667/44686/summary.html
COMMIT: e352dff
CMSSW: CMSSW_15_1_X_2025-02-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47439/44686/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending code-checks-approved orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_15_1_X
Development

Successfully merging this pull request may close these issues.
3 participants
@perrotta @cmsbuild @mmusich