[NANO] Fix PS weight parsing

[hqucms]

PR description:

This PR fixes the parsing of parton shower weight names in GenWeightsTableProducer.

It seems that with the update of Pythia to 8.309 (cms-sw/cmsdist#8552) the name of the PS weights in GenLumiInfoHeader changed from fsr:murfac=0.5 to fsr.murfac=0.5. This PR fixes the parsing to take into account both cases. Without the fix, the producer simply takes the weights at indices 6--10 which do not correspond to the nominal isr/fsr variations.

Along with the fix, the branch doc string of PSWeight is also updated to fill in actual branch names from the header to provide a cross check.

PR validation:

Tested with NANO workflows.

FYI - @cms-sw/generators-l2

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47253/43542

[cmsbuild]

A new Pull Request was created by @hqucms for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[hqucms]

enable nano

[hqucms]

please test

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcba0f/44167/summary.html
COMMIT: 4ac2ce7
CMSSW: CMSSW_15_0_X_2025-02-03-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47253/44167/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4016938
• DQMHistoTests: Total failures: 109
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4016809
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 268 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 21
• DQMHistoTests: Total histograms compared: 75219
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 75219
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
• Checked 106 log files, 61 edm output root files, 21 DQM output files
• TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	3.114	3.114	0.000 ( +0.0% )	6.29	6.42	-2.1%	2.543	2.550
2500.002	3.230	3.230	0.000 ( +0.0% )	5.65	5.72	-1.3%	2.560	2.984
2500.003	3.171	3.171	0.000 ( +0.0% )	5.90	6.01	-1.9%	2.950	2.956
2500.011	1.644	1.644	0.000 ( +0.0% )	10.06	10.27	-2.1%	2.635	2.627
2500.012	2.184	2.184	0.000 ( +0.0% )	5.90	6.00	-1.7%	2.440	2.818
2500.013	2.000	2.000	0.000 ( +0.0% )	8.31	8.44	-1.5%	2.723	2.727
2500.021	0.022	0.022	0.000 ( +0.0% )	2.05	2.08	-1.4%	2.612	2.603
2500.022	0.022	0.022	0.000 ( +0.0% )	1.99	1.99	-0.3%	2.597	2.604
2500.023	0.022	0.022	0.000 ( +0.0% )	1.87	1.89	-1.2%	2.461	2.470
2500.024	0.022	0.022	0.000 ( +0.0% )	1.56	1.56	-0.2%	2.696	2.703
2500.031	0.035	0.035	0.000 ( +0.0% )	1.77	1.76	+0.6%	2.658	2.657
2500.032	0.036	0.036	0.000 ( +0.0% )	1.80	1.82	-1.0%	2.626	2.620
2500.033	0.037	0.037	0.000 ( +0.0% )	1.72	1.70	+1.1%	2.705	2.707
2500.034	0.036	0.036	0.000 ( +0.0% )	1.71	1.71	+0.2%	2.681	2.682
2500.101	2.847	2.847	0.000 ( +0.0% )	16.45	16.54	-0.5%	2.642	2.642
2500.111	1.465	1.465	0.000 ( +0.0% )	31.69	31.89	-0.6%	2.331	2.326
2500.112	1.885	1.885	0.000 ( +0.0% )	25.84	25.59	+1.0%	2.371	2.408
2500.131	0.750	0.750	0.000 ( +0.0% )	37.79	37.66	+0.3%	1.401	1.508
2500.201	2.676	2.676	0.000 ( +0.0% )	13.79	13.90	-0.8%	2.151	2.208
2500.211	1.833	1.833	0.000 ( +0.0% )	27.16	27.53	-1.4%	2.108	2.400
2500.212	2.229	2.229	0.000 ( +0.0% )	22.48	22.50	-0.1%	1.951	2.495
2500.221	2.038	2.038	0.000 ( +0.0% )	14.49	14.61	-0.8%	2.073	2.120
2500.222	3.482	3.482	0.000 ( +0.0% )	13.33	13.25	+0.6%	1.673	2.220
2500.223	9.493	9.493	0.000 ( +0.0% )	4.30	4.30	+0.1%	1.790	2.290
2500.224	6.547	6.547	0.000 ( +0.0% )	1.40	1.42	-1.3%	2.234	2.288
2500.225	6.594	6.594	0.000 ( +0.0% )	1.29	1.31	-1.1%	2.435	2.505
2500.226	3.175	3.175	0.000 ( +0.0% )	13.93	13.76	+1.2%	2.210	2.212
2500.227	1.442	1.442	0.000 ( +0.0% )	23.84	23.99	-0.6%	1.446	1.442
2500.228	3.959	3.959	0.000 ( +0.0% )	8.99	9.24	-2.7%	2.248	2.321
2500.231	1.457	1.457	0.000 ( +0.0% )	22.73	23.00	-1.2%	2.299	2.290
2500.232	2.489	2.489	0.000 ( +0.0% )	21.09	21.47	-1.8%	2.199	2.399
2500.233	4.988	4.988	0.000 ( +0.0% )	6.15	6.31	-2.5%	2.254	2.468
2500.234	3.884	3.884	0.000 ( +0.0% )	1.76	1.80	-1.8%	2.177	2.434
2500.235	3.916	3.916	0.000 ( +0.0% )	1.65	1.69	-2.1%	2.381	2.634
2500.236	2.278	2.278	0.000 ( +0.0% )	21.55	22.72	-5.1%	2.394	2.394
2500.237	1.018	1.018	0.000 ( +0.0% )	34.43	35.60	-3.3%	1.451	1.460
2500.238	2.466	2.466	0.000 ( +0.0% )	17.11	17.51	-2.3%	2.470	2.487
2500.241	9.404	9.404	0.000 ( +0.0% )	6.49	6.43	+0.8%	1.925	1.927
2500.242	10.331	10.331	0.000 ( +0.0% )	1.69	1.58	+6.9%	1.726	1.727
2500.243	2.712	2.712	0.000 ( +0.0% )	15.77	15.82	-0.3%	1.061	1.061
2500.244	486.016	486.016	0.000 ( +0.0% )	1.14	1.15	-1.1%	1.688	1.685
2500.245	826.413	826.413	0.000 ( +0.0% )	1.53	1.55	-1.3%	1.672	1.695
2500.251	645.314	645.314	0.000 ( +0.0% )	1.65	1.68	-2.0%	1.788	1.788
2500.901	1.819	1.819	0.000 ( +0.0% )	44.37	45.66	-2.8%	1.445	1.447
2500.902	1.665	1.665	0.000 ( +0.0% )	47.02	49.19	-4.4%	1.335	1.336
2500.911	14.345	14.345	0.000 ( +0.0% )	8.60	8.39	+2.5%	1.084	1.087
2500.912	0.150	0.240	-0.090 ( -37.5% )	2.40	3.55	-32.4%	0.847	0.844
2500.913	0.110	0.110	0.000 ( +0.0% )	2.48	2.63	-5.6%	0.776	0.851

[hqucms]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1