Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix tests for reMINI + NANOv15 #47231

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Jan 31, 2025

PR description:

Add 2 matrix tests for reMINI + NANOv15 on 2024 140X MC and data.

PR validation:

runTheMatrix.py -w nano --ibeos -l 2500.301,2500.311

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47231/43511

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hqucms for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor Author

hqucms commented Jan 31, 2025

enable nano

@hqucms
Copy link
Contributor Author

hqucms commented Jan 31, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-033246/44113/summary.html
COMMIT: 64b4a1b
CMSSW: CMSSW_15_0_X_2025-01-31-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47231/44113/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016770
  • DQMHistoTests: Total failures: 77
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4016673
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 1035 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 75127
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 75127
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
  • Checked 106 log files, 61 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.301-size.json
  • Nano ERROR: Missing ref/2500.301-size.json
  • Nano ERROR: Missing ref/2500.311-size.json
  • Nano ERROR: Missing ref/2500.311-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.001 | 3.114 | 3.114 | 0.000 ( +0.0% ) | 6.23 | 6.41 | -2.8% | 2.541 | 2.561 |
    | 2500.002 | 3.230 | 3.230 | 0.000 ( +0.0% ) | 5.61 | 5.72 | -2.1% | 2.971 | 2.994 |
    | 2500.003 | 3.171 | 3.171 | 0.000 ( +0.0% ) | 5.84 | 5.97 | -2.2% | 2.956 | 2.984 |
    | 2500.011 | 1.644 | 1.644 | 0.000 ( +0.0% ) | 9.88 | 10.22 | -3.3% | 2.628 | 2.643 |
    | 2500.012 | 2.184 | 2.184 | 0.000 ( +0.0% ) | 5.84 | 5.99 | -2.5% | 2.772 | 2.833 |
    | 2500.013 | 2.000 | 2.000 | 0.000 ( +0.0% ) | 8.20 | 8.43 | -2.7% | 2.653 | 2.735 |
    | 2500.021 | 0.022 | 0.022 | 0.000 ( +0.0% ) | 1.89 | 2.08 | -9.0% | 2.500 | 2.610 |
    | 2500.022 | 0.022 | 0.022 | 0.000 ( +0.0% ) | 1.81 | 1.98 | -8.5% | 2.502 | 2.612 |
    | 2500.023 | 0.022 | 0.022 | 0.000 ( +0.0% ) | 1.77 | 1.89 | -6.4% | 2.422 | 2.479 |
    | 2500.024 | 0.022 | 0.022 | 0.000 ( +0.0% ) | 1.45 | 1.55 | -5.9% | 2.570 | 2.702 |
    | 2500.031 | 0.035 | 0.035 | 0.000 ( +0.0% ) | 1.63 | 1.76 | -7.6% | 2.598 | 2.662 |
    | 2500.032 | 0.036 | 0.036 | 0.000 ( +0.0% ) | 1.69 | 1.81 | -6.2% | 2.564 | 2.637 |
    | 2500.033 | 0.037 | 0.037 | 0.000 ( +0.0% ) | 1.61 | 1.70 | -5.6% | 2.641 | 2.704 |
    | 2500.034 | 0.036 | 0.036 | 0.000 ( +0.0% ) | 1.58 | 1.72 | -8.3% | 2.622 | 2.694 |
    | 2500.101 | 2.844 | 2.844 | 0.000 ( +0.0% ) | 15.86 | 16.38 | -3.2% | 2.599 | 2.652 |
    | 2500.111 | 1.463 | 1.463 | 0.000 ( +0.0% ) | 29.65 | 31.53 | -6.0% | 2.325 | 2.344 |
    | 2500.112 | 1.883 | 1.883 | 0.000 ( +0.0% ) | 24.87 | 25.68 | -3.2% | 2.402 | 2.417 |
    | 2500.131 | 0.750 | 0.750 | 0.000 ( +0.0% ) | 36.85 | 37.57 | -1.9% | 1.498 | 1.509 |
    | 2500.201 | 2.674 | 2.674 | 0.000 ( +0.0% ) | 13.19 | 13.69 | -3.6% | 2.201 | 2.219 |
    | 2500.211 | 1.806 | 1.806 | 0.000 ( +0.0% ) | 25.77 | 27.34 | -5.7% | 2.399 | 2.415 |
    | 2500.212 | 2.203 | 2.203 | 0.000 ( +0.0% ) | 21.68 | 22.42 | -3.3% | 2.482 | 2.498 |
    | 2500.221 | 2.038 | 2.038 | 0.000 ( +0.0% ) | 13.87 | 14.50 | -4.4% | 2.117 | 2.129 |
    | 2500.222 | 3.479 | 3.479 | 0.000 ( +0.0% ) | 12.76 | 13.21 | -3.4% | 2.216 | 2.228 |
    | 2500.223 | 9.444 | 9.444 | 0.000 ( +0.0% ) | 4.20 | 4.29 | -2.0% | 2.118 | 2.306 |
    | 2500.224 | 6.480 | 6.480 | 0.000 ( +0.0% ) | 1.39 | 1.41 | -1.6% | 2.279 | 2.299 |
    | 2500.225 | 6.527 | 6.527 | 0.000 ( +0.0% ) | 1.28 | 1.31 | -1.8% | 2.482 | 2.507 |
    | 2500.226 | 3.172 | 3.172 | 0.000 ( +0.0% ) | 13.52 | 13.67 | -1.1% | 2.209 | 2.222 |
    | 2500.227 | 1.442 | 1.442 | 0.000 ( +0.0% ) | 23.66 | 23.89 | -1.0% | 1.446 | 1.457 |
    | 2500.228 | 3.957 | 3.957 | 0.000 ( +0.0% ) | 8.96 | 9.17 | -2.2% | 2.312 | 2.320 |
    | 2500.231 | 1.457 | 1.457 | 0.000 ( +0.0% ) | 22.00 | 22.92 | -4.0% | 2.288 | 2.299 |
    | 2500.232 | 2.462 | 2.462 | 0.000 ( +0.0% ) | 20.47 | 21.06 | -2.8% | 2.371 | 2.404 |
    | 2500.233 | 4.954 | 4.954 | 0.000 ( +0.0% ) | 6.12 | 6.24 | -1.8% | 2.467 | 2.487 |
    | 2500.234 | 3.844 | 3.844 | 0.000 ( +0.0% ) | 1.76 | 1.80 | -2.0% | 2.269 | 2.443 |
    | 2500.235 | 3.876 | 3.876 | 0.000 ( +0.0% ) | 1.65 | 1.68 | -2.3% | 2.441 | 2.641 |
    | 2500.236 | 2.252 | 2.252 | 0.000 ( +0.0% ) | 21.70 | 22.54 | -3.7% | 2.392 | 2.393 |
    | 2500.237 | 1.018 | 1.018 | 0.000 ( +0.0% ) | 34.47 | 35.55 | -3.0% | 1.463 | 1.468 |
    | 2500.238 | 2.444 | 2.444 | 0.000 ( +0.0% ) | 17.10 | 17.59 | -2.8% | 2.483 | 2.494 |
    | 2500.241 | 9.404 | 9.404 | 0.000 ( +0.0% ) | 7.41 | 7.43 | -0.2% | 1.925 | 1.932 |
    | 2500.242 | 10.331 | 10.331 | 0.000 ( +0.0% ) | 1.65 | 1.67 | -1.2% | 1.723 | 1.730 |
    | 2500.243 | 2.712 | 2.712 | 0.000 ( +0.0% ) | 15.50 | 14.95 | +3.7% | 1.063 | 1.070 |
    | 2500.244 | 486.016 | 486.016 | 0.000 ( +0.0% ) | 1.14 | 1.15 | -0.7% | 1.706 | 1.720 |
    | 2500.245 | 826.413 | 826.413 | 0.000 ( +0.0% ) | 1.53 | 1.55 | -1.1% | 1.695 | 1.689 |
    | 2500.251 | 645.314 | 645.314 | 0.000 ( +0.0% ) | 1.66 | 1.69 | -2.0% | 1.788 | 1.790 |
    | 2500.901 | 1.819 | 1.819 | 0.000 ( +0.0% ) | 44.07 | 46.34 | -4.9% | 1.448 | 1.454 |
    | 2500.902 | 1.665 | 1.665 | 0.000 ( +0.0% ) | 47.05 | 47.90 | -1.8% | 1.333 | 1.346 |
    | 2500.911 | 14.345 | 14.345 | 0.000 ( +0.0% ) | 8.01 | 9.29 | -13.8% | 1.087 | 1.100 |
    | 2500.912 | 0.199 | 0.240 | -0.041 ( -16.9% ) | 2.87 | 3.01 | -4.6% | 0.851 | 0.853 |
    | 2500.913 | 0.110 | 0.110 | 0.000 ( +0.0% ) | 2.62 | 2.60 | +0.8% | 0.847 | 0.859 |

@hqucms
Copy link
Contributor Author

hqucms commented Feb 1, 2025

+1

@hqucms
Copy link
Contributor Author

hqucms commented Feb 4, 2025

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 Could you please review and sign? We would like to get this in for CMSSW_15_0_0_pre3.

@Moanwar
Copy link
Contributor

Moanwar commented Feb 4, 2025

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 753c9f9 into cms-sw:master Feb 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants