Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025 PU and Wfs for PR Testing and GPU #47161

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

AdrianoDee
Copy link
Contributor

PR description:

This PR proposes to:

  • fix the PU used for 2025 wfs (now AVE_35_BX_25ns);
  • ad a PU 2025 wf to the limited matrix;
  • update the GPU RelVals with 2025 conditions.

PR validation:

None

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 22, 2025

cms-bot internal usage

@AdrianoDee AdrianoDee changed the title 2025 pu and wfs 2025 PU and Wfs for PR Testing and GPU Jan 22, 2025
@AdrianoDee
Copy link
Contributor Author

enable gpu

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • relval_opts_gpu= -w upgrade
  • relval_gpu=16834.402, 17034.402

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Size: This PR adds an extra 76KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98cbba/43902/summary.html
COMMIT: 9e893ac
CMSSW: CMSSW_15_0_X_2025-01-21-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47161/43902/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

SyntaxError: invalid syntax

gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:2020: CompilePython] Error 1
gmake[1]: Target 'PostBuild' not remade because of errors.
gmake[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_0_X_2025-01-21-2300'
gmake: *** [config/SCRAM/GMake/Makefile.rules:1906: src] Error 2
gmake: Target 'all' not remade because of errors.
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2
Command exited with non-zero status 2
	Command being timed: "scram b -v -k -j 16"
	User time (seconds): 176.08


@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47161/43393

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47161/43395

@cmsbuild
Copy link
Contributor

Pull request #47161 was updated. @AdrianoDee, @Moanwar, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 76KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98cbba/43914/summary.html
COMMIT: 8ce979a
CMSSW: CMSSW_15_0_X_2025-01-22-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47161/43914/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3819085
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3819050
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 214 log files, 184 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 74 differences found in the comparisons
  • DQMHistoTests: Total files compared: 9
  • DQMHistoTests: Total histograms compared: 84999
  • DQMHistoTests: Total failures: 11295
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 73704
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 8 files compared)
  • Checked 32 log files, 40 edm output root files, 9 DQM output files
  • TriggerResults: found differences in 1 / 8 workflows

@AdrianoDee
Copy link
Contributor Author

+pdmv

@AdrianoDee
Copy link
Contributor Author

Hi @cms-sw/upgrade-l2 any comment on this? Thanks!

@Moanwar
Copy link
Contributor

Moanwar commented Jan 27, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 47e2c5f into cms-sw:master Jan 27, 2025
15 checks passed
@AdrianoDee AdrianoDee deleted the 2025_pu_and_wfs branch January 27, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants