[Nano, JMENano] Updates for V15 #47157

nurfikri89 · 2025-01-21T18:19:10Z

PR description:

This PR is a follow up of #46981. The following changes are made:

By default, JMENano does not need to recluster AK4 Gen jets but take slimmedGenJets directly with pt > 5 GeV cut. - - Fixed a bug concerning duplication of some FatJetForJEC branches.
Increase precision of jet pt and mass.
Add jet composition branches for genjets.
Define SimpleGenJetFlatTableProducer and use it for Gen jets in main Nano and JMENano.
Fix genSubJetAK8Table source in nanogen_cff.py.

PR validation:

Event size increase from 5.95 kb/event to 6.10 kb/event. Tested with RunIII2024Summer24 private reMini TTto4Q sample.
passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos with the exception of a few workflows which failed because of missing relval input files.
passes MiniAOD workflows: runTheMatrix.py -i all --ibeos -l 2500.021,2500.022,2500.023,2500.024,2500.031,2500.032,2500.033,2500.034

… genjets in jetMC_cff.py

…cut. Fix duplicate branches for FatJetForJEC. Add more genjet branches. Increase jet pt & mass precisions. General cleanup

cmsbuild · 2025-01-21T18:19:35Z

cms-bot internal usage

cmsbuild · 2025-01-21T18:21:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47157/43387

There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/plugins/SimpleFlatTableProducerPlugins.cc modified in PR(s): [NGT] Implement NanoAOD ntuples production for HLT Muon objects #47069

cmsbuild · 2025-01-21T18:21:48Z

A new Pull Request was created by @nurfikri89 for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

hqucms · 2025-01-21T21:36:03Z

enable nano

hqucms · 2025-01-21T21:36:08Z

please test

cmsbuild · 2025-01-21T23:33:11Z

-1

Failed Tests: RelVals-NANO
Size: This PR adds an extra 56KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e0b49/43893/summary.html
COMMIT: a3ef2a6
CMSSW: CMSSW_15_0_X_2025-01-21-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47157/43893/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-NANO

2500.9132500.913_TTbar_Pow_LHE_13TeV/step3_TTbar_Pow_LHE_13TeV.log
2500.9122500.912_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV/step3_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV.log
2500.9112500.911_DYToLL_M-50_13TeV_pythia8/step2_DYToLL_M-50_13TeV_pythia8.log

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3819085
DQMHistoTests: Total failures: 70
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3818995
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 214 log files, 184 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2025-01-22T15:24:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47157/43397

There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/plugins/SimpleFlatTableProducerPlugins.cc modified in PR(s): [NGT] Implement NanoAOD ntuples production for HLT Muon objects #47069

cmsbuild · 2025-01-22T15:24:45Z

Pull request #47157 was updated. @cmsbuild, @ftorrresd, @hqucms can you please check and sign again.

hqucms · 2025-01-22T17:23:55Z

please test

cmsbuild · 2025-01-22T19:23:00Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e0b49/43918/summary.html
COMMIT: a553440
CMSSW: CMSSW_15_0_X_2025-01-22-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47157/43918/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3819085
DQMHistoTests: Total failures: 18
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3819047
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 214 log files, 184 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 920 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 21
DQMHistoTests: Total histograms compared: 75127
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 75127
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
Checked 105 log files, 60 edm output root files, 21 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	3.114	3.114	0.000 ( +0.0% )	6.42	5.50	+16.7%	2.558	2.546
2500.002	3.230	3.230	0.000 ( +0.0% )	5.76	5.00	+15.2%	2.982	2.976
2500.003	3.171	3.171	0.000 ( +0.0% )	6.01	5.17	+16.2%	2.966	2.963
2500.011	1.644	1.644	0.000 ( +0.0% )	10.28	8.72	+17.8%	2.639	2.632
2500.012	2.184	2.184	0.000 ( +0.0% )	6.02	5.20	+15.8%	2.813	2.828
2500.013	2.000	2.000	0.000 ( +0.0% )	8.46	7.12	+18.8%	2.728	2.729
2500.021	0.022	0.022	0.000 ( +0.0% )	2.05	1.88	+9.5%	2.600	2.596
2500.022	0.022	0.022	0.000 ( +0.0% )	1.93	1.80	+6.8%	2.598	2.596
2500.023	0.022	0.022	0.000 ( +0.0% )	1.90	1.73	+10.2%	2.462	2.467
2500.024	0.022	0.022	0.000 ( +0.0% )	1.56	1.46	+7.2%	2.708	2.702
2500.031	0.035	0.035	0.000 ( +0.0% )	1.75	1.65	+6.2%	2.646	2.659
2500.032	0.036	0.036	0.000 ( +0.0% )	1.78	1.64	+8.4%	2.614	2.620
2500.033	0.037	0.037	0.000 ( +0.0% )	1.69	1.59	+6.1%	2.699	2.695
2500.034	0.036	0.036	0.000 ( +0.0% )	1.71	1.58	+8.2%	2.682	2.674
2500.101	2.844	2.844	0.000 ( +0.0% )	16.61	14.47	+14.7%	2.642	2.639
2500.111	1.463	1.463	0.000 ( +0.0% )	31.93	28.16	+13.4%	2.336	2.337
2500.112	1.883	1.883	0.000 ( +0.0% )	26.10	23.47	+11.2%	2.406	2.404
2500.131	0.750	0.750	0.000 ( +0.0% )	37.87	34.78	+8.9%	1.405	1.507
2500.201	2.674	2.674	0.000 ( +0.0% )	13.77	10.96	+25.7%	2.153	2.210
2500.211	1.806	1.806	0.000 ( +0.0% )	27.69	24.21	+14.4%	2.394	2.406
2500.212	2.203	2.203	0.000 ( +0.0% )	22.28	20.22	+10.2%	2.486	2.490
2500.221	2.038	2.038	0.000 ( +0.0% )	14.52	13.07	+11.1%	2.068	2.126
2500.222	3.479	3.479	0.000 ( +0.0% )	13.35	12.24	+9.1%	2.164	2.220
2500.223	9.444	9.444	0.000 ( +0.0% )	4.30	3.95	+8.6%	2.240	2.293
2500.224	6.480	6.304	0.177 ( +2.8% )	1.42	1.17	+21.5%	2.285	2.280
2500.225	6.527	6.350	0.177 ( +2.8% )	1.31	1.08	+21.8%	2.457	2.451
2500.226	3.172	3.172	0.000 ( +0.0% )	14.01	12.53	+11.8%	2.215	2.212
2500.227	1.442	1.442	0.000 ( +0.0% )	24.18	20.80	+16.3%	1.445	1.441
2500.228	3.957	3.957	0.000 ( +0.0% )	9.16	7.55	+21.3%	2.310	2.311
2500.231	1.456	1.456	0.000 ( +0.0% )	23.33	20.85	+11.9%	2.291	2.290
2500.232	2.462	2.462	0.000 ( +0.0% )	21.60	18.85	+14.6%	2.401	2.392
2500.233	4.954	4.954	0.000 ( +0.0% )	6.26	5.03	+24.4%	2.472	2.471
2500.234	3.844	3.842	0.002 ( +0.1% )	1.80	1.45	+23.9%	2.178	2.184
2500.235	3.876	3.873	0.002 ( +0.1% )	1.69	1.34	+26.7%	2.383	2.376
2500.236	2.252	2.252	0.000 ( +0.0% )	22.53	14.24	+58.2%	2.389	2.387
2500.237	1.018	1.018	0.000 ( +0.0% )	35.56	27.21	+30.7%	1.453	1.458
2500.238	2.444	2.444	0.000 ( +0.0% )	17.58	14.62	+20.2%	2.471	2.477
2500.241	9.404	9.404	0.000 ( +0.0% )	6.73	4.83	+39.4%	1.927	1.925
2500.242	10.331	10.331	0.000 ( +0.0% )	1.72	1.26	+35.9%	1.724	1.724
2500.243	2.712	2.712	0.000 ( +0.0% )	16.03	11.81	+35.7%	1.060	1.060
2500.244	486.016	486.016	0.000 ( +0.0% )	1.15	0.84	+36.9%	1.690	1.677
2500.245	826.413	826.413	0.000 ( +0.0% )	1.54	1.16	+33.3%	1.702	1.694
2500.901	1.819	1.819	0.000 ( +0.0% )	44.65	40.84	+9.3%	1.444	1.441
2500.902	1.665	1.665	0.000 ( +0.0% )	48.57	43.27	+12.2%	1.337	1.337
2500.911	14.345	14.345	0.000 ( +0.0% )	7.95	7.70	+3.2%	1.083	1.087
2500.912	0.240	0.171	0.069 ( +40.2% )	2.75	2.79	-1.3%	0.844	0.843
2500.913	0.110	0.110	0.000 ( +0.0% )	2.68	2.23	+20.3%	0.849	0.851

hqucms · 2025-01-24T21:54:18Z

+1

cmsbuild · 2025-01-24T21:54:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-01-25T07:49:56Z

+1

nurfikri89 added 4 commits January 20, 2025 14:37

Add SimpleFlatTableProducer for reco::GenJet and switch to it for all…

7d86716

… genjets in jetMC_cff.py

Fix typo for neEmEF

7848809

Do not recluster AK4 Gen jets but take from slimmedGenJets with pt>5 …

35db9fb

…cut. Fix duplicate branches for FatJetForJEC. Add more genjet branches. Increase jet pt & mass precisions. General cleanup

Update nanojmeDQM_cff with missing genjet collections

a3ef2a6

cmsbuild added this to the CMSSW_15_0_X milestone Jan 21, 2025

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Jan 21, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 21, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 21, 2025

cmsbuild added tests-rejected and removed tests-started labels Jan 21, 2025

Set the right source for genSubJetAK8Table

a553440

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Jan 22, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 22, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 22, 2025

cmsbuild added tests-approved and removed tests-started labels Jan 22, 2025

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Jan 24, 2025

cmsbuild added orp-approved and removed orp-pending labels Jan 25, 2025

cmsbuild merged commit af88c52 into cms-sw:master Jan 25, 2025
13 checks passed

cmsbuild mentioned this pull request Jan 28, 2025

[GCC13] Update to latest changes from gcc 13 branch cms-sw/cmsdist#9634

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Nano, JMENano] Updates for V15 #47157

[Nano, JMENano] Updates for V15 #47157

nurfikri89 commented Jan 21, 2025 •

edited

Loading

cmsbuild commented Jan 21, 2025 •

edited

Loading

cmsbuild commented Jan 21, 2025

cmsbuild commented Jan 21, 2025

hqucms commented Jan 21, 2025

hqucms commented Jan 21, 2025

cmsbuild commented Jan 21, 2025

cmsbuild commented Jan 22, 2025

cmsbuild commented Jan 22, 2025

hqucms commented Jan 22, 2025

cmsbuild commented Jan 22, 2025

hqucms commented Jan 24, 2025

cmsbuild commented Jan 24, 2025

mandrenguyen commented Jan 25, 2025

[Nano, JMENano] Updates for V15 #47157

[Nano, JMENano] Updates for V15 #47157

Conversation

nurfikri89 commented Jan 21, 2025 • edited Loading

PR description:

PR validation:

cmsbuild commented Jan 21, 2025 • edited Loading

cmsbuild commented Jan 21, 2025

cmsbuild commented Jan 21, 2025

hqucms commented Jan 21, 2025

hqucms commented Jan 21, 2025

cmsbuild commented Jan 21, 2025

RelVals-NANO

Comparison Summary

cmsbuild commented Jan 22, 2025

cmsbuild commented Jan 22, 2025

hqucms commented Jan 22, 2025

cmsbuild commented Jan 22, 2025

Comparison Summary

NANO Comparison Summary

hqucms commented Jan 24, 2025

cmsbuild commented Jan 24, 2025

mandrenguyen commented Jan 25, 2025

nurfikri89 commented Jan 21, 2025 •

edited

Loading

cmsbuild commented Jan 21, 2025 •

edited

Loading