Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DQM] Update compareDQMOutput.py #46854

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[DQM] Update compareDQMOutput.py #46854

merged 1 commit into from
Dec 5, 2024

Conversation

nothingface0
Copy link
Contributor

PR description:

Add a -u/--dqmgui-url argument, which allows specifying the DQMGUI url to upload the results to. Defaults to https://cmsweb.cern.ch/dqm/dev/

This is so that the script can be used decoupled from the specific DQMGUI, and can be used on private machines as well.

PR validation:

None, will be done through the cmsbuild tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be

Not a backport.

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Dec 3, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46854/42878

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

A new Pull Request was created by @nothingface0 for master.

It involves the following packages:

  • DQMServices/FileIO (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@rseidita
Copy link
Contributor

rseidita commented Dec 3, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78d8bf/43214/summary.html
COMMIT: a46895e
CMSSW: CMSSW_15_0_X_2024-12-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46854/43214/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78d8bf/43214/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78d8bf/43214/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3484682
  • DQMHistoTests: Total failures: 427
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3484235
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@nothingface0
Copy link
Contributor Author

nothingface0 commented Dec 3, 2024 •
edited
Loading

@smuzaffar Could you point me to where the execution logs of compareDQMOutput.py are?

Nevermind, found it!

@nothingface0
Update compareDQMOutput.py
7371cbc 
Add a `-u`/`--dqmgui-url` argument which allows
to specify the DQMGUI url to upload the results to.
Defaults to `https://cmsweb.cern.ch/dqm/dev/`
@nothingface0
Copy link
Contributor Author

nothingface0 commented Dec 3, 2024 •
edited
Loading

It seems like the upload failed due to me forgetting to pass the new argument to the started threads running upload.

@rseidita This commit should fix it 7371cbc, could you re-start the test please?

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46854/42882

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

Pull request #46854 was updated. @antoniovagnerini, @cmsbuild, @rseidita can you please check and sign again.

@rseidita
Copy link
Contributor

rseidita commented Dec 3, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78d8bf/43220/summary.html
COMMIT: 7371cbc
CMSSW: CMSSW_15_0_X_2024-12-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46854/43220/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78d8bf/43220/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-78d8bf/43220/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3484682
  • DQMHistoTests: Total failures: 1816
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3482846
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@nothingface0
Copy link
Contributor Author

Looks like it worked as expected.

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 640040c into cms-sw:master Dec 5, 2024
11 checks passed
This was referenced Dec 5, 2024
Merged
Merged
@nothingface0 nothingface0 deleted the patch-1 branch December 11, 2024 11:58
@nothingface0 nothingface0 mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_15_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@nothingface0 @cmsbuild @rseidita @antoniovagnerini @mandrenguyen