trackGenJetAK4 added #46627

pasenov · 2024-11-07T18:08:46Z

I have added trackGenJetAK4 to jetMC_cff.py. It is used to produce a list of genJets that are made with charged particles only (fulfilling some criteria). The only changes made are in PhysicsTools/NanoAOD/python/nanogen_cff.py and PhysicsTools/NanoAOD/python/jetMC_cff.py.

cmsbuild · 2024-11-07T18:09:08Z

cms-bot internal usage

cmsbuild · 2024-11-07T18:10:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46627/42531

cmsbuild · 2024-11-07T18:10:40Z

A new Pull Request was created by @pasenov for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

ftorrresd · 2024-11-11T15:09:49Z

enable nano

ftorrresd · 2024-11-11T15:18:04Z

please test

cmsbuild · 2024-11-11T18:24:56Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1faf08/42732/summary.html
COMMIT: b151cab
CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46627/42732/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 32 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3343588
DQMHistoTests: Total failures: 415
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343153
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 202 log files, 172 edm output root files, 46 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 485 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 21
DQMHistoTests: Total histograms compared: 55722
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 55722
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
Checked 102 log files, 58 edm output root files, 21 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	3.106	3.052	0.054 ( +1.8% )	2.72	2.70	+0.7%	2.509	2.506
2500.002	3.221	3.164	0.056 ( +1.8% )	2.44	2.42	+0.8%	2.938	2.946
2500.003	3.159	3.105	0.054 ( +1.7% )	2.55	2.53	+0.9%	2.919	2.926
2500.011	1.621	1.621	0.000 ( +0.0% )	4.17	4.12	+1.2%	2.610	2.598
2500.012	2.153	2.153	0.000 ( +0.0% )	2.53	2.52	+0.4%	2.789	2.795
2500.013	1.975	1.975	0.000 ( +0.0% )	3.54	3.50	+1.2%	2.703	2.701
2500.021	0.022	0.022	0.000 ( +0.0% )	0.85	0.86	-0.2%	2.549	2.550
2500.022	0.022	0.022	0.000 ( +0.0% )	0.79	0.83	-4.0%	2.554	2.546
2500.023	0.022	0.022	0.000 ( +0.0% )	0.81	0.82	-1.5%	2.413	2.421
2500.024	0.022	0.022	0.000 ( +0.0% )	0.63	0.62	+0.6%	2.642	2.642
2500.031	0.035	0.035	0.000 ( +0.0% )	0.74	0.74	+0.0%	2.623	2.616
2500.032	0.036	0.036	0.000 ( +0.0% )	0.74	0.74	-0.1%	2.585	2.583
2500.033	0.037	0.037	0.000 ( +0.0% )	0.68	0.69	-1.2%	2.663	2.666
2500.034	0.036	0.036	0.000 ( +0.0% )	0.69	0.70	-1.1%	2.646	2.644
2500.101	2.846	2.788	0.058 ( +2.1% )	6.63	6.56	+1.0%	2.613	2.610
2500.111	1.447	1.447	0.000 ( +0.0% )	13.10	13.16	-0.4%	2.318	2.323
2500.112	1.867	1.867	0.000 ( +0.0% )	11.24	11.12	+1.1%	2.396	2.390
2500.131	0.747	0.747	0.000 ( +0.0% )	17.25	16.96	+1.7%	1.509	1.480
2500.201	2.671	2.617	0.055 ( +2.1% )	5.67	5.49	+3.2%	2.175	2.174
2500.211	1.786	1.786	0.000 ( +0.0% )	11.43	11.21	+1.9%	2.387	2.381
2500.212	2.182	2.182	0.000 ( +0.0% )	9.78	9.37	+4.4%	2.465	2.456
2500.221	2.028	2.028	0.000 ( +0.0% )	5.85	5.83	+0.3%	2.087	2.088
2500.222	3.473	3.415	0.058 ( +1.7% )	5.53	5.47	+1.0%	2.180	2.179
2500.223	9.438	9.380	0.058 ( +0.6% )	1.70	1.67	+1.7%	2.254	2.209
2500.224	6.121	6.063	0.058 ( +1.0% )	0.57	0.56	+0.6%	2.243	2.199
2500.225	6.168	6.111	0.058 ( +0.9% )	0.54	0.53	+1.6%	2.415	2.401
2500.226	3.167	3.109	0.058 ( +1.9% )	5.71	5.58	+2.4%	2.179	2.124
2500.227	1.437	1.437	0.000 ( +0.0% )	11.13	10.90	+2.2%	1.432	1.429
2500.231	1.449	1.449	0.000 ( +0.0% )	9.61	9.28	+3.5%	2.272	2.271
2500.232	2.441	2.441	0.000 ( +0.0% )	9.11	8.92	+2.2%	2.377	2.379
2500.233	4.933	4.933	0.000 ( +0.0% )	2.50	2.44	+2.3%	2.442	2.433
2500.234	3.700	3.700	0.000 ( +0.0% )	0.72	0.70	+3.3%	2.169	2.403
2500.235	3.730	3.730	0.000 ( +0.0% )	0.69	0.69	+0.6%	2.369	2.605
2500.236	2.232	2.232	0.000 ( +0.0% )	9.68	9.36	+3.4%	2.373	2.379
2500.237	1.016	1.016	0.000 ( +0.0% )	16.16	16.01	+0.9%	1.457	1.461
2500.241	9.404	9.404	0.000 ( +0.0% )	3.61	3.35	+7.6%	1.920	1.921
2500.242	10.331	10.331	0.000 ( +0.0% )	0.85	0.81	+5.3%	1.709	1.708
2500.243	2.712	2.712	0.000 ( +0.0% )	8.06	7.87	+2.5%	1.079	1.069
2500.244	485.976	485.976	0.000 ( +0.0% )	0.52	0.52	+0.9%	1.671	1.672
2500.245	823.202	823.202	0.000 ( +0.0% )	0.70	0.69	+2.7%	1.666	1.658
2500.901	1.834	1.777	0.058 ( +3.2% )	19.41	19.35	+0.3%	1.420	1.418
2500.902	1.684	1.626	0.058 ( +3.6% )	19.78	19.97	-1.0%	1.325	1.323
2500.911	14.398	13.995	0.403 ( +2.9% )	3.73	3.48	+7.2%	1.090	1.086
2500.912	0.199	0.438	-0.239 ( -54.5% )	1.34	1.17	+14.5%	0.973	0.973
2500.913	0.110	0.110	0.000 ( +0.0% )	1.10	1.11	-0.6%	0.978	0.977

hqucms · 2024-11-11T22:45:12Z

The changes add ~2% to MC NANOs. Is this trackGenJetAK4Table needed for the standard NANO, or only for NANOGEN?

pasenov · 2024-11-12T22:26:35Z

The changes add ~2% to MC NANOs. Is this trackGenJetAK4Table needed for the standard NANO, or only for NANOGEN?

Yes, it is essential for our analysis to have trackGenJetAK4Table also in the standard NANO

arizzi · 2024-11-18T09:18:48Z

Hi @hqucms , this is the corresponding MC information to what is in SoftActivity related variables that are already there. We can probably apply (much) more aggressive compresion and/or ,as we do in reco variables, only store the first N genjets plus some counters over threshold.

hqucms · 2024-11-19T15:26:51Z

Hi @hqucms , this is the corresponding MC information to what is in SoftActivity related variables that are already there. We can probably apply (much) more aggressive compresion and/or ,as we do in reco variables, only store the first N genjets plus some counters over threshold.

Hi @arizzi -- indeed those would be good to try to keep the size under control.
BTW is this for FlashSim, or for some analyses? It would be nice to add some context information to the PR title and description.

arizzi · 2024-11-19T15:33:16Z

The main usage is now for FlashSim, but in fact it is "a bug" not to have some corresponding MC information to a given reco variables (we added for the same reasons years ago a few Gen level fat/sub jets collections that I do not think are really used in any analysis)

arizzi · 2024-11-20T09:13:41Z

@hqucms Patrick is updating the PR setting the precision to similar precision as for RECO for these jets. Adding the limit at 6 (and adding the counters) is probably not making a large difference at GEN level because the number of jets seems to be in average below 6. Can you run the size checks again after the coming PR update from @pasenov ?

cmsbuild · 2025-01-08T13:15:48Z

Pull request #46627 was updated. @cmsbuild, @ftorrresd, @hqucms can you please check and sign again.

cmsbuild · 2025-01-08T13:23:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46627/43206

There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Add muonBestTrackType value #47031

cmsbuild · 2025-01-08T13:23:38Z

Pull request #46627 was updated. @cmsbuild, @ftorrresd, @hqucms can you please check and sign again.

pasenov · 2025-01-08T13:24:07Z

Hi @ftorrresd ,

Thank you for the suggestion. I added TrackGenJetAK4 to the nanoDQM as well.

Best,
P.

ftorrresd · 2025-01-09T13:10:29Z

please abort

ftorrresd · 2025-01-09T13:11:03Z

please test

cmsbuild · 2025-01-09T15:36:50Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1faf08/43696/summary.html
COMMIT: dd83fa3
CMSSW: CMSSW_15_0_X_2025-01-09-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46627/43696/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 33 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3818530
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3818500
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 46.73599999999999 KiB( 48 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 2.735 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 13234.0,... ): 1.912 KiB Physics/NanoAODDQM
Checked 214 log files, 184 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 361 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 21
DQMHistoTests: Total histograms compared: 74806
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 74806
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 27.058999999999994 KiB( 20 files compared)
DQMHistoSizes: changed ( 2500.001,... ): 2.735 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 2500.011,... ): 1.912 KiB Physics/NanoAODDQM
Checked 105 log files, 60 edm output root files, 21 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	3.110	3.076	0.034 ( +1.1% )	6.37	5.02	+26.9%	2.536	2.550
2500.002	3.227	3.192	0.035 ( +1.1% )	5.69	4.49	+26.6%	2.553	2.978
2500.003	3.167	3.133	0.034 ( +1.1% )	5.94	4.65	+27.8%	2.565	2.962
2500.011	1.644	1.644	0.000 ( +0.0% )	10.06	7.63	+31.8%	2.635	2.635
2500.012	2.184	2.184	0.000 ( +0.0% )	5.93	4.69	+26.4%	2.427	2.812
2500.013	1.999	1.999	0.000 ( +0.0% )	8.37	6.43	+30.1%	2.420	2.725
2500.021	0.022	0.022	0.000 ( +0.0% )	2.00	1.46	+36.6%	2.606	2.595
2500.022	0.022	0.022	0.000 ( +0.0% )	1.93	1.41	+37.4%	2.602	2.594
2500.023	0.022	0.022	0.000 ( +0.0% )	1.86	1.40	+32.7%	2.473	2.467
2500.024	0.022	0.022	0.000 ( +0.0% )	1.52	1.17	+29.5%	2.699	2.694
2500.031	0.035	0.035	0.000 ( +0.0% )	1.73	1.36	+27.5%	2.653	2.650
2500.032	0.036	0.036	0.000 ( +0.0% )	1.75	1.34	+30.7%	2.620	2.612
2500.033	0.037	0.037	0.000 ( +0.0% )	1.68	1.25	+34.2%	2.703	2.703
2500.034	0.036	0.036	0.000 ( +0.0% )	1.63	1.26	+29.5%	2.684	2.677
2500.101	2.840	2.803	0.037 ( +1.3% )	16.22	11.94	+35.8%	2.627	2.636
2500.111	1.462	1.462	0.000 ( +0.0% )	30.40	23.01	+32.2%	2.318	2.332
2500.112	1.882	1.882	0.000 ( +0.0% )	24.80	19.47	+27.4%	2.389	2.400
2500.131	0.750	0.750	0.000 ( +0.0% )	36.53	28.24	+29.4%	1.503	1.513
2500.201	2.674	2.637	0.036 ( +1.4% )	13.53	9.66	+40.0%	2.198	2.203
2500.211	1.805	1.805	0.000 ( +0.0% )	26.75	19.93	+34.2%	2.395	2.391
2500.212	2.202	2.202	0.000 ( +0.0% )	21.93	16.18	+35.6%	2.475	2.481
2500.221	2.037	2.037	0.000 ( +0.0% )	14.20	10.18	+39.4%	2.118	2.123
2500.222	3.478	3.440	0.038 ( +1.1% )	12.99	9.38	+38.5%	2.213	2.215
2500.223	9.443	9.406	0.038 ( +0.4% )	4.21	3.13	+34.3%	2.290	2.292
2500.224	6.303	6.265	0.038 ( +0.6% )	1.40	1.07	+31.1%	2.269	2.220
2500.225	6.350	6.312	0.038 ( +0.6% )	1.30	1.00	+30.5%	2.494	2.445
2500.226	3.171	3.134	0.038 ( +1.2% )	13.44	10.44	+28.8%	2.201	2.204
2500.227	1.442	1.442	0.000 ( +0.0% )	23.78	18.32	+29.8%	1.450	1.440
2500.228	3.956	3.921	0.035 ( +0.9% )	9.11	6.90	+32.1%	2.301	2.301
2500.231	1.455	1.455	0.000 ( +0.0% )	22.79	17.17	+32.7%	2.279	2.291
2500.232	2.461	2.461	0.000 ( +0.0% )	21.10	14.87	+41.9%	2.394	2.394
2500.233	4.953	4.953	0.000 ( +0.0% )	6.23	4.62	+34.9%	2.470	2.473
2500.234	3.841	3.841	0.000 ( +0.0% )	1.80	1.38	+30.5%	2.414	2.184
2500.235	3.872	3.872	0.000 ( +0.0% )	1.67	1.29	+29.9%	2.621	2.368
2500.236	2.251	2.251	0.000 ( +0.0% )	22.44	15.77	+42.3%	2.386	2.391
2500.237	1.018	1.018	0.000 ( +0.0% )	35.58	27.27	+30.5%	1.458	1.453
2500.238	2.443	2.443	0.000 ( +0.0% )	17.52	13.61	+28.8%	2.468	2.473
2500.241	9.404	9.404	0.000 ( +0.0% )	7.29	5.47	+33.3%	1.923	1.925
2500.242	10.331	10.331	0.000 ( +0.0% )	1.70	1.35	+25.7%	1.726	1.726
2500.243	2.712	2.712	0.000 ( +0.0% )	15.82	11.54	+37.1%	1.056	1.065
2500.244	486.016	486.016	0.000 ( +0.0% )	1.14	0.89	+28.4%	1.679	1.685
2500.245	826.413	826.413	0.000 ( +0.0% )	1.54	1.13	+35.7%	1.668	1.690
2500.901	1.816	1.778	0.038 ( +2.1% )	45.84	33.45	+37.1%	1.445	1.442
2500.902	1.665	1.628	0.038 ( +2.3% )	49.05	37.83	+29.7%	1.338	1.334
2500.911	14.345	14.041	0.303 ( +2.2% )	8.66	6.90	+25.6%	1.089	1.081
2500.912	0.199	0.729	-0.530 ( -72.7% )	2.92	1.93	+51.5%	0.851	0.846
2500.913	0.110	0.110	0.000 ( +0.0% )	2.66	1.99	+33.9%	0.848	0.850

ftorrresd · 2025-01-13T15:26:59Z

+1

cmsbuild · 2025-01-13T15:27:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-01-13T19:06:24Z

+1

trackGenJetAK4 added

b151cab

cmsbuild added this to the CMSSW_14_2_X milestone Nov 7, 2024

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Nov 7, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 7, 2024

cmsbuild added tests-started and removed tests-pending labels Nov 11, 2024

cmsbuild added tests-approved and removed tests-started labels Nov 11, 2024

trackGenJetAK4Table: precision changed for pt, eta, phi

f3efa2d

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Nov 20, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 8, 2025

TrackGenJetAK4 added to nanoDQM; manually removing btagUParTCvNotB

dd83fa3

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 8, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 8, 2025

cmsbuild added tests-started and removed tests-pending labels Jan 9, 2025

cmsbuild added tests-approved and removed tests-started labels Jan 9, 2025

cmsbuild mentioned this pull request Jan 9, 2025

Add Mother Indices to LHEPart #47075

Merged

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Jan 13, 2025

cmsbuild added orp-approved and removed orp-pending labels Jan 13, 2025

cmsbuild merged commit 7b424a3 into cms-sw:master Jan 13, 2025
13 checks passed

cmsbuild mentioned this pull request Jan 14, 2025

Pythia 8.313 cms-sw/cmsdist#9612

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

trackGenJetAK4 added #46627

trackGenJetAK4 added #46627

pasenov commented Nov 7, 2024

cmsbuild commented Nov 7, 2024 •

edited

Loading

cmsbuild commented Nov 7, 2024

cmsbuild commented Nov 7, 2024

ftorrresd commented Nov 11, 2024

ftorrresd commented Nov 11, 2024

cmsbuild commented Nov 11, 2024

hqucms commented Nov 11, 2024

pasenov commented Nov 12, 2024

arizzi commented Nov 18, 2024

hqucms commented Nov 19, 2024

arizzi commented Nov 19, 2024

arizzi commented Nov 20, 2024

cmsbuild commented Jan 8, 2025

cmsbuild commented Jan 8, 2025

cmsbuild commented Jan 8, 2025

pasenov commented Jan 8, 2025

ftorrresd commented Jan 9, 2025

ftorrresd commented Jan 9, 2025

cmsbuild commented Jan 9, 2025

ftorrresd commented Jan 13, 2025

cmsbuild commented Jan 13, 2025

mandrenguyen commented Jan 13, 2025

trackGenJetAK4 added #46627

trackGenJetAK4 added #46627

Conversation

pasenov commented Nov 7, 2024

cmsbuild commented Nov 7, 2024 • edited Loading

cmsbuild commented Nov 7, 2024

cmsbuild commented Nov 7, 2024

ftorrresd commented Nov 11, 2024

ftorrresd commented Nov 11, 2024

cmsbuild commented Nov 11, 2024

Comparison Summary

NANO Comparison Summary

hqucms commented Nov 11, 2024

pasenov commented Nov 12, 2024

arizzi commented Nov 18, 2024

hqucms commented Nov 19, 2024

arizzi commented Nov 19, 2024

arizzi commented Nov 20, 2024

cmsbuild commented Jan 8, 2025

cmsbuild commented Jan 8, 2025

cmsbuild commented Jan 8, 2025

pasenov commented Jan 8, 2025

ftorrresd commented Jan 9, 2025

ftorrresd commented Jan 9, 2025

cmsbuild commented Jan 9, 2025

Comparison Summary

NANO Comparison Summary

ftorrresd commented Jan 13, 2025

cmsbuild commented Jan 13, 2025

mandrenguyen commented Jan 13, 2025

cmsbuild commented Nov 7, 2024 •

edited

Loading