quarter core processor for HL-LHC inner tracker developments

[sihyunjeon]

PR description:

This introduces the quarter core processing of RD53 chips in inner trackers for HL-LHC era. It reads the pixel digis to fully reconstruct the raw detector hits and convert it into the format of RD53 chip output readings.
Relevant studies were presented in several DPG meetings in the past (picked one [1]) and also has been documented for last year's EDR review [2]. Recently also has been shown in tracker backend systems (BES) meetings as well [3]

[1] https://indico.cern.ch/event/1304700/contributions/5492757/attachments/2682398/4653346/20230711_dps_trackerweek_itsimulation.pdf
[2] https://indico.cern.ch/event/1323095/contributions/5567145/attachments/2735303/4756343/ITDataRate_v3.pdf
[3] https://indico.cern.ch/event/1394715/contributions/5863117/attachments/2828164/4941229/trackerbesofflinesw_20240307_dataformat_handling_in_innertracker.pdf

PR validation:

Results from this PR have been tested against old standalone workflow in C++ (without any CMSSW dependencies) that were used to get the results in [1] and [2] with the workflow defined in EventFilter/Phase2TrackerRawToDigi/test/Phase2ITDigiToRaw_cfg.py.

@zdemirag @tomalin @sroychow

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45759/41470

• Found files with invalid states:
  • EventFilter/Phase2TrackerRawToDigi/plugins/PixelQCoreSimple.cc:
    • Added: ad3934e
    • Deleted: 4e2fc09

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45759/41470/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45759/41470/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45759/41471

• Found files with invalid states:
  • EventFilter/Phase2TrackerRawToDigi/plugins/PixelQCoreSimple.cc:
    • Added: ad3934e
    • Deleted: 4e2fc09

[cmsbuild]

A new Pull Request was created by @sihyunjeon for master.

It involves the following packages:

• DataFormats/Phase2TrackerDigi (reconstruction, upgrade)
• EventFilter/Phase2TrackerRawToDigi (reconstruction, daq)

@cmsbuild, @emeschi, @jfernan2, @mandrenguyen, @smorovic, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45759/41484

• Found files with invalid states:
  • DataFormats/Phase2TrackerDigi/src/Hit.cc:
    • Added: ad3934e
    • Modified: 4e2fc09, c6adcd9
    • Deleted: fba35d1
  • EventFilter/Phase2TrackerRawToDigi/plugins/PixelQCoreSimple.cc:
    • Added: ad3934e
    • Deleted: 4e2fc09
  • DataFormats/Phase2TrackerDigi/interface/Hit.h:
    • Added: ad3934e
    • Modified: 4e2fc09, c6adcd9
    • Deleted: fba35d1

[cmsbuild]

Pull request #45759 was updated. @cmsbuild, @emeschi, @jfernan2, @mandrenguyen, @smorovic, @srimanob, @subirsarkar can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45759/41486

• Found files with invalid states:
  • DataFormats/Phase2TrackerDigi/src/Hit.cc:
    • Added: ad3934e
    • Modified: 4e2fc09, c6adcd9
    • Deleted: fba35d1
  • EventFilter/Phase2TrackerRawToDigi/plugins/PixelQCoreSimple.cc:
    • Added: ad3934e
    • Deleted: 4e2fc09
  • DataFormats/Phase2TrackerDigi/interface/Hit.h:
    • Added: ad3934e
    • Modified: 4e2fc09, c6adcd9
    • Deleted: fba35d1

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45759/43106

• Found files with invalid states:
  • EventFilter/Phase2PixelRawToDigi/test/plugins/Phase2PixelQCoreNtuple.cc:
    • Added: 5a35f2c
    • Deleted: 63fae6f

[cmsbuild]

Pull request #45759 was updated. @Moanwar, @cmsbuild, @emeschi, @jfernan2, @mandrenguyen, @smorovic, @srimanob, @subirsarkar can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8787f8/43582/summary.html
COMMIT: 6118c11
CMSSW: CMSSW_15_0_X_2024-12-19-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45759/43582/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 197 lines from the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3818210
• DQMHistoTests: Total failures: 399
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3817791
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

@sihyunjeon have the comments from @makortel been resolved or they go into another PR? Thanks

[sihyunjeon]

@jfernan2 there is one comment related to xml but this doesn't affect any other code in CMSSW. if it's possible can we put them in so that we can close this for now and then i follow up in a new PR? there is bunch of other codes that needs to be pushed in as well but pending for this to be merged

[jfernan2]

+1

[smorovic]

+daq

[sihyunjeon]

@Moanwar hey, can you check this for the upgrade?

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1