Adding HepMC3 products to EDMProduct #38033

SiewYan · 2022-05-21T10:21:04Z

PR description:

This PR trying to address the EDM addition in #37187 , using advises from twiki [*].
The HepMC3 package adapted new strategy to manipulate event records of High Energy Physics Monte Carlo Event Generators (MCEGs) [**], notably:

Particles and vertices are stored separately in an ordered graph structure; all custom iterators were removed.
Extension on the I/O functionality of the library.

[*] https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCreatingNewProducts
[**] https://iopscience.iop.org/article/10.1088/1742-6596/1525/1/012017/pdf

The HepMC3 new data format poses challenges on defining the corresponding EDMProduct definition.

This PR depicts partial implementation, due to some technical error:

Error: Class shared_ptr<HepMC3::GenParticle> has been selected but currently the support for its I/O is not yet available. Note that shared_ptr<HepMC3::GenParticle>, even if not selected, will be available for interpreted code.
Error: Class shared_ptr<HepMC3::GenVertex> has been selected but currently the support for its I/O is not yet available. Note that shared_ptr<HepMC3::GenVertex>, even if not selected, will be available for interpreted code.

I am looking for advice(s) on how to solve the error. @smuzaffar, @mkirsano

Note: class version will be done accordingly after a successful compilation with the amended version classes_def.xml.

Related Issue/PR:

Issue Migrate CMSSW from HepMC2 to HepMC3 #36662
configure pythia8 to use hepmc3: #7677
Add generator hepmc3 products #37187
Add HepMC3 products and methods to Generator base clases #37689
Add to Pythia8Interface the plugin that produces HepMC3 products #37753

PR validation:

No validation yet, to be finalized as the PR evolve..

if this PR is a backport please specify the original PR and why you need to backport that PR:

NA

cmsbuild · 2022-05-21T10:26:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38033/30110

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimDataFormats/GeneratorProducts/src/classes.h modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File SimDataFormats/GeneratorProducts/src/classes_def.xml modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167

cmsbuild · 2022-05-21T10:26:41Z

A new Pull Request was created by @SiewYan (Siewyan Hoh 何守仁) for master.

It involves the following packages:

SimDataFormats/GeneratorProducts (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@apsallid, @rovere, @bsunanda, @lecriste, @ebrondol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

SiewYan · 2022-05-21T10:27:52Z

FYI: @imranyusuff

SiewYan · 2022-05-21T10:30:48Z

please test

cmsbuild · 2022-05-21T11:09:38Z

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10e534/24892/summary.html
COMMIT: 13c562c
CMSSW: CMSSW_12_5_X_2022-05-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38033/24892/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/src/SimDataFormats/GeneratorProducts/src/LHEXMLStringProduct.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/src/SimDataFormats/GeneratorProducts/src/hepmc_rootio.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/src/SimDataFormats/GeneratorProducts/src/HepEvt.F
Error: Class shared_ptr has been selected but currently the support for its I/O is not yet available. Note that shared_ptr, even if not selected, will be available for interpreted code.
Error: Class shared_ptr has been selected but currently the support for its I/O is not yet available. Note that shared_ptr, even if not selected, will be available for interpreted code.
gmake: *** [tmp/el8_amd64_gcc10/src/SimDataFormats/GeneratorProducts/src/SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc] Error 1
>> Compiling LCG dictionary: tmp/el8_amd64_gcc10/src/SimDataFormats/GeneratorProducts/src/SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc
c++: error: SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
gmake: *** [tmp/el8_amd64_gcc10/src/SimDataFormats/GeneratorProducts/src/SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc.o] Error 1

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package SimDataFormats/GeneratorProducts
>> Compile sequence completed for CMSSW CMSSW_12_5_X_2022-05-21-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --ignoreWarning=Wdeprecated-declarations --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/tmp/el8_amd64_gcc10/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package SimDataFormats/GeneratorProducts
Entering library rule at SimDataFormats/GeneratorProducts
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/src/SimDataFormats/GeneratorProducts/src/GenEventInfoProduct.cc

SiewYan · 2022-07-26T07:21:56Z

please test

cmsbuild · 2022-07-26T07:26:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38033/31271

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimDataFormats/GeneratorProducts/src/classes.h modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167
- File SimDataFormats/GeneratorProducts/src/classes_def.xml modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167

bbilin · 2024-09-03T09:04:48Z

This is superseeded by #44603 and can be closed, thanks to @mseidel42

cmsbuild · 2024-11-22T13:10:53Z

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

mkirsano · 2024-11-26T15:55:32Z

I also think that this can be closed

cmsbuild · 2025-02-07T08:31:47Z

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

cmsbuild · 2025-02-07T08:34:08Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10e534/44255/summary.html
COMMIT: 21e1444
CMSSW: CMSSW_15_0_X_2025-02-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38033/44255/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10e534/44255/git-merge-result

mkirsano · 2025-02-07T08:41:53Z

Please close this PR, it is obsolete and not needed anymore

tentative HepMC3 products definition

13c562c

cmsbuild added this to the CMSSW_12_5_X milestone May 21, 2022

cmsbuild added code-checks-pending generators-pending orp-pending pending-signatures tests-pending labels May 21, 2022

SiewYan mentioned this pull request May 21, 2022

Migrate CMSSW from HepMC2 to HepMC3 #36662

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels May 21, 2022

cmsbuild added tests-started and removed tests-pending labels May 21, 2022

cmsbuild added tests-rejected and removed tests-started labels May 21, 2022

cmsbuild mentioned this pull request Jun 21, 2022

Refactoring gen weight storage in EDM + Nano integration #32167

Closed

using compiled version

f112dcb

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Jul 26, 2022

cmsbuild added tests-started and removed tests-pending labels Jul 26, 2022

cmsbuild removed the code-checks-pending label Jul 26, 2022

cmsbuild modified the milestones: CMSSW_14_2_X, CMSSW_14_1_X Aug 27, 2024

cmsbuild added the changes-dataformats label Aug 27, 2024

cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Sep 3, 2024

cmsbuild mentioned this pull request Oct 14, 2024

Fix memory leak in GenParticles2HepMCConverter #46203

Merged

cmsbuild mentioned this pull request Nov 6, 2024

Updated to new RNTuple version #46615

Merged

cmsbuild modified the milestones: CMSSW_14_2_X, CMSSW_15_0_X Nov 22, 2024

cmsbuild modified the milestones: CMSSW_15_0_X, CMSSW_15_1_X Feb 7, 2025

cmsbuild added tests-started and removed tests-approved labels Feb 7, 2025

cmsbuild added tests-rejected and removed tests-started labels Feb 7, 2025

cmsbuild modified the milestones: CMSSW_15_0_X, CMSSW_15_1_X Feb 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding HepMC3 products to EDMProduct #38033

Adding HepMC3 products to EDMProduct #38033

SiewYan commented May 21, 2022 •

edited

Loading

cmsbuild commented May 21, 2022

cmsbuild commented May 21, 2022 •

edited

Loading

SiewYan commented May 21, 2022

SiewYan commented May 21, 2022

cmsbuild commented May 21, 2022

SiewYan commented Jul 26, 2022

cmsbuild commented Jul 26, 2022

bbilin commented Sep 3, 2024

cmsbuild commented Nov 22, 2024

mkirsano commented Nov 26, 2024

cmsbuild commented Feb 7, 2025

cmsbuild commented Feb 7, 2025

mkirsano commented Feb 7, 2025

Adding HepMC3 products to EDMProduct #38033

Are you sure you want to change the base?

Adding HepMC3 products to EDMProduct #38033

Conversation

SiewYan commented May 21, 2022 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 21, 2022

cmsbuild commented May 21, 2022 • edited Loading

SiewYan commented May 21, 2022

SiewYan commented May 21, 2022

cmsbuild commented May 21, 2022

Build

Clang Build

SiewYan commented Jul 26, 2022

cmsbuild commented Jul 26, 2022

bbilin commented Sep 3, 2024

cmsbuild commented Nov 22, 2024

mkirsano commented Nov 26, 2024

cmsbuild commented Feb 7, 2025

cmsbuild commented Feb 7, 2025

mkirsano commented Feb 7, 2025

SiewYan commented May 21, 2022 •

edited

Loading

cmsbuild commented May 21, 2022 •

edited

Loading