Update FWCore/ParameterSet headers

[Dr15Jones]

PR description:

• Moved ParameterSet headers to src if not needed for API
• replaced getFixedSizedArray.h with generic mechanism to get arbitrary types via call to ParameterSet::get(Untracked)Parameter

PR validation:

Code compiles.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31429/18293

• This PR adds an extra 60KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Integration
FWCore/ParameterSet

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-10-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9251/console Started: 2020/09/10 20:28

[cmsbuild]

+1
Tested at: c13ed23
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3df28a/9251/summary.html
CMSSW: CMSSW_11_2_X_2020-09-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Fix for Gauss3D in BeamMonitor #31408 @jfernan2: Fix for Gauss3D in BeamMonitor
• clean magField->nominalValue() #31394 @mtosi: clean magField->nominalValue()
• move FFTJet.h header to reduce circular dependencies #31370 @davidlange6: move FFTJet.h header to reduce circular dependencies

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3df28a/9251/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3df28a/9251/git-merge-result

[cmsbuild]

Comparison job queued.

[makortel]

This is beyond this PR, but I want to wonder out loud the usefulness of the (char const* name) overloads given that under the hood a std::string gets constructed anyway

cmssw/FWCore/ParameterSet/src/ParameterSet.cc

Line 219 in 53c50cd

Entry const& ParameterSet::retrieve(char const* name) const { return retrieve(std::string(name)); }

Should we (later) look into replacing both std::string const& and char const* overloads with a single std::string_view?

[Dr15Jones]

I would like to explore that. I think one reason for both std::string and char const* is how templated functions fall within the overload function set. I'm guessing in the past we needed both else automatic conversion was not happening.

[wddgit]

It has been a long time and I might not be remembering this correctly, but I believe the reason we added both interfaces was that use of the char const* interface was causing the conversion to string to be inlined in many many places during the build, which was not efficient. I am remembering what other people said. This is not something I tested myself.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3df28a/9251/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2620284
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2620261
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1