Pr ultra legacy ps weigts

[Andrej-CMS]

Hi all,

this is the backport of #26905 for UltraLegacy.
please test with WF 535

[cmsbuild]

A new Pull Request was created by @Andrej-CMS for CMSSW_10_6_X.

It involves the following packages:

Configuration/Generator
GeneratorInterface/Herwig7Interface

@alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Herwig7 fix seg fault master #26905

[qliphy]

please test workflow 535

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1422/console Started: 2019/07/11 14:25

[cmsbuild]

+1
Tested at: 601889f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6cc0d1/1422/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6cc0d1/1422/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-6cc0d1/535.0_TTbar_13TeV_Pow_herwig7+TTbar_13TeV_Pow_herwig7+HARVESTGEN

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3208248
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3207911
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@qliphy so I understand that this code was explicitly validated in 11_0_X , found to be ok and now it is backported into 10_6_X. Are the differences compared to the original PR just due to the code formatting?

[qliphy]

@fabiocos
"Are the differences compared to the original PR just due to the code formatting?"
@Andrej-CMS should comment here.

[Andrej-CMS]

@fabiocos
yes, the differences are due to code formatting.

[srimanob]

As I see there is a part of using getGenLumiInfoHeader in the file. Could you please confirm that it will still work well along with the PR
#27446 (see comment)
i.e. you still have information passed to MiniAOD, NanoAOD.

[fabiocos]

@efeyazgan @qliphy @agrohjse this is another question related to the UL setup

[kpedro88]

backport of #26905

[kpedro88]

@Andrej-CMS @efeyazgan @qliphy @agrohsje can you address the question in #27496 (comment) ?

[qliphy]

@gourangakole has done some checks and will give an update soon.

[gourangakole]

This is the details check for #27446
July2019_Gouranga_PR27446_v0.pdf
after_GS_LHEheader.txt
after_MiniAODSIM.txt

[kpedro88]

@gourangakole it is not entirely clear to me how this material answers the question. Can you elaborate on your conclusions from your studies?

[gourangakole]

@kpedro88 ..I am sorry for the confusion. I am quite new in these checks.
But my checks are entirely related to the
#27446 (comment)
@qliphy @fabiocos @efeyazgan do you think my checks #27496 (comment) are fine for the #27446 (comment)

[qliphy]

Chesk from @gourangakole is mainly on #27446 (comment) by validating on LHERunInfoProduct.h and GenLumiInfoProduct.h

Here indeed should be further checked on herwig7. @Andrej-CMS may help here？

[Andrej-CMS]

@kpedro88 @fabiocos
You can find the validation of the PSweights in Herwig7 in the presentation below:
https://indico.cern.ch/event/783798/contributions/3517950/attachments/1890688/3117965/20190806_HerwigUpdate.pdf

You can see that the information gets propagated to MiniAODSIM for example in the sample below which has been produced centrally:

https://cmsweb.cern.ch/das/request?view=list&limit=50&instance=prod%2Fglobal&input=%2FTT_TuneCH3_13TeV-powheg-herwig7%2FRunIIFall17MiniAODv2-PU2017_12Apr2018_94X_mc2017_realistic_v14-v2%2FMINIAODSIM

[fabiocos]

+1