Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppi candidates for b tagging of Puppi jets in all eras (91X) #18667

Conversation

ferencek
Copy link
Contributor

This is a 91X backport of #18666

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_9_1_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

1 similar comment
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_9_1_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19725/console Started: 2017/05/10 16:38

@slava77
Copy link
Contributor

slava77 commented May 10, 2017

@ferencek
release 91X is closed for new features

Please close this PR of provide justification why this has to go in.
Nominally, JME BTV POG has to invalidate the latest 91X campaign for this to go in.

@ferencek
Copy link
Contributor Author

@slava77, can you please clarify what this JME POG campaign is? What release is being used for it?

As far as I see, the final 9_1_0 hasn't yet been cut so I was under the impression that small analysis-level changes to MiniAOD are still allowed.

@slava77
Copy link
Contributor

slava77 commented May 10, 2017 via email

@ferencek
Copy link
Contributor Author

@slava77, OK, in this case @imarches and @carolinecollard should comment as well but I think it is fine for the BTV POG to have this feature included starting from the 92X release cycle and there is no need to invalidate the latest 91X relval campaign just for this reason. However, if it gets invalidated for some other reason, I guess we could then sneak in this PR, right?

@slava77
Copy link
Contributor

slava77 commented May 10, 2017 via email

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18667/19725/summary.html

Comparison Summary:

  • You potentially added 33 lines to the logs
  • Reco comparison results: 3304 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831084
  • DQMHistoTests: Total failures: 33534
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1797370
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@ferencek
Copy link
Contributor Author

@slava77, if that means that for stable data-taking in June we plan to use 92X, then I think we can close this PR.

@ferencek ferencek changed the title Puppi candidates for b tagging of Puppi jets in all era (91X) Puppi candidates for b tagging of Puppi jets in all eras (91X) May 10, 2017
@slava77
Copy link
Contributor

slava77 commented May 11, 2017

backport of #18666

@slava77
Copy link
Contributor

slava77 commented May 11, 2017

+1

for #18667 6d68c61

  • the same commit/topic branch as the 92X version Puppi candidates for b tagging of Puppi jets in all eras #18666 . This changes b-tag discriminator variables in the default miniAOD AK4 puppi jets.
    • This PR can be merged if other features go in to 91X as part of miniAOD or other related (upstream) changes
    • I put this PR on hold to be more clear that it's not ready to merge by (not)change policy

@slava77
Copy link
Contributor

slava77 commented May 11, 2017

hold

  • I put this PR on hold to be more clear that it's not ready to merge by (not)change policy

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @slava77
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@davidlange6
Copy link
Contributor

Closing PR. CMSSW_9_1_X is for muon TDR upgrade changes only (CMSSW_9_2_X for data taking)

@ferencek ferencek deleted the PuppiForBTagging-PR_from-CMSSW_9_1_0_pre3 branch May 17, 2017 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants