-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puppi candidates for b tagging of Puppi jets in all eras (91X) #18667
Puppi candidates for b tagging of Puppi jets in all eras (91X) #18667
Conversation
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_9_1_X. It involves the following packages: PhysicsTools/PatAlgos @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
1 similar comment
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_9_1_X. It involves the following packages: PhysicsTools/PatAlgos @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@ferencek Please close this PR of provide justification why this has to go in. |
@slava77, can you please clarify what this JME POG campaign is? What release is being used for it? As far as I see, the final 9_1_0 hasn't yet been cut so I was under the impression that small analysis-level changes to MiniAOD are still allowed. |
On 5/10/17 7:57 AM, Dinko Ferencek wrote:
@slava77 <https://github.com/slava77>, can you please clarify what this
JME POG campaign is? What release is being used for it?
Sorry, I meant "BTV"
As far as I see, the final 9_1_0 hasn't yet been cut so I was under the
impression that small analysis-level changes to MiniAOD are still allowed.
miniAOD is a part of the standard workflow.
So, no more changes are expected, unless it's a bug.
And to be declared a bug, the responsible group should invalidate the
release in the latest relval campaing.
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18667 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbpv-fO5bpDc3mm_1TtW1dO9KvVNLks5r4dBpgaJpZM4NWuJa>.
|
@slava77, OK, in this case @imarches and @carolinecollard should comment as well but I think it is fine for the BTV POG to have this feature included starting from the 92X release cycle and there is no need to invalidate the latest 91X relval campaign just for this reason. However, if it gets invalidated for some other reason, I guess we could then sneak in this PR, right? |
On 5/10/17 8:10 AM, Dinko Ferencek wrote:
@slava77 <https://github.com/slava77>, OK, in this case @imarches
<https://github.com/imarches> and @carolinecollard
<https://github.com/carolinecollard> should comment as well but I think
it is fine for the BTV POG to have this feature included starting from
the 92X release cycle and there is no need to invalidate the latest 91X
relval campaign just for this reason. However, if it gets invalidated
for some other reason, I guess we could then sneak in this PR, right?
due to issues with pixel geometry, the 91X will be a very short cycle,
aiming [in the context of phase-1/0 standard miniAOD] primarily
for just May commissioning with beams and CTPPS detectors.
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18667 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbtRRAwt483tXzLrVzYLS2SBk9XiFks5r4dNMgaJpZM4NWuJa>.
|
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@slava77, if that means that for stable data-taking in June we plan to use 92X, then I think we can close this PR. |
backport of #18666 |
+1 for #18667 6d68c61
|
hold
|
Pull request has been put on hold by @slava77 |
Closing PR. CMSSW_9_1_X is for muon TDR upgrade changes only (CMSSW_9_2_X for data taking) |
This is a 91X backport of #18666