Resolve ambiguity with TColor ctors #13335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With recent change in ROOT: https://root.cern.ch/gitweb?p=root.git;a=commitdiff;h=8ebf9227adcf410134a5733086616ed70de55da3 We gained additional TColor ctor. The problem in CMSSW was that the first argument was neither Int_t nor Float_t. It all 4 places it was unsinged int. According to the compiler both TColor ctors are valid, it can call either of them. We have to be more explicit that we want the first ctor. Thus cast the first argument to Int_t to match the first ctor signature. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_8_0_X. It involves the following packages: Fireworks/Core @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @alja, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
Closed
|
I just scheduled the test via Jenkins. |
|
Thanks! |
davidlange6
added a commit
that referenced
this pull request
Feb 18, 2016
Resolve ambiguity with TColor ctors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent change in ROOT: https://root.cern.ch/gitweb?p=root.git;a=commitdiff;h=8ebf9227adcf410134a5733086616ed70de55da3
We gained additional TColor ctor. The problem in CMSSW was that the
first argument was neither Int_t nor Float_t. It all 4 places it was
unsinged int. According to the compiler both TColor ctors are valid, it
can call either of them.
We have to be more explicit that we want the first ctor. Thus cast the
first argument to Int_t to match the first ctor signature.
This does not change behaviour, that was previously done by the compiler.
Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch