Add gct unpacker back into stage-1 unpacking sequence #13310
Conversation
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
A new Pull Request was created by @mulhearn for CMSSW_8_0_X. It involves the following packages: L1Trigger/Configuration @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| @@ -33,7 +33,7 @@ def unpack_legacy(): | |||
|
|
|||
|
|
|||
| def unpack_stage1(): | |||
| global csctfDigis, dttfDigis, gtDigis,caloStage1Digis,caloStage1FinalDigis | |||
| global csctfDigis, dttfDigis, gtDigis,caloStage1Digis,caloStage1FinalDigis,gctDigis | |||
There was a problem hiding this comment.
@mulhearn - I had missed these globals.. we'll need to remove them at some point very soon. why are they needed here?
|
The globals are just so that this can be organized as modules? Why is this any different then (not in a subroutine): which we do all the time? |
|
Maybe I don't understand global variables in python. I can fix this quickly if you want, I'll just have to move all the import statements out of the subroutines. Or this can wait until a planned future update: I want to move this to a mode where every unpacker always runs, but maybe only the "required for the era" unpackers are allowed to complain (once) if their payloads are empty. |
|
ah - its not what I thought at first - is ok - though indeed we'll need to rearrange this somewhat eventually. |
|
+1 |
Add gct unpacker back into stage-1 unpacking sequence
This PR adds gct unpacking back into Stage-1 unpacking sequence, as expected by the offline DQM.
This should quiet HLT GRUN validation errors from recent IB @Martin-Grunewald