recover particleFlowClusterHF in event content

[slava77]

Fix PF event content to keep HF PFClusters and "Cleaned" rechits.

• particleFlowClusterHF previously (before 72X) were split in HFEM and HFHAD collections. RECO and FEVT was never updated to keep recoPFClusters_particleFlowClusterHF.
  • this at some point affected running recoMET_pfClusterMet_cfg.py in RecoMET/METProducers unit tests which was first mitigated in Fix of the 76X recoMET tests #10818 in the test itself (instead of adding clusters to RECO). The METProducers kept running thanks to rather inclusive fastsim event content "keep _particleFlow**", until the fastsim event content was cleaned up in 80X in Fastsim: eventcontent configuration : cleanup #13090 .
  • A more appropriate fix is to keep HF PFClusters and not attempt to remake them in recoMET_pfClusterMet_cfg.py
• Missing recoPFClusters_particleFlowClusterHF in RECO was also reported by FSQ.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11256/console

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_0_X.

It involves the following packages:

RecoMET/METProducers
RecoParticleFlow/Configuration

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @lgray, @jdolen, @nhanvtran, @schoef, @mariadalfonso, @bachtis this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[cmsbuild]

-1
Tested at: 6721bd4
When I ran the RelVals I found an error in the following worklfows:
1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13309/11256/summary.html

[slava77]

@cmsbuild please test
maybe no DAS error next time

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11258/console

[cmsbuild]

+1
Tested at: 6721bd4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13309/11258/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13309/11258/summary.html

[slava77]

+1

for #13309 6721bd4

• restores particleFlowClusterHF in RECO/FEVT event content
• jenkins tests pass and comparisons with baseline show no differences
• checks in local tests confirm that the RECO output files now have recoPFClusters_particleFlowClusterHF included in the output (about 3%); AOD is unchanged.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1