bsunanda:Run2-hcx66 Changes to Simulation for 2016++ scenario

[bsunanda]

Some fixes to HcalTopology and HcalDDDRecConstants
Fix Full and Fast Sim for multianode readout of HF

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_8_0_X.

It involves the following packages:

FastSimulation/Calorimetry
FastSimulation/ShowerDevelopment
Geometry/CaloTopology
Geometry/HcalCommonData
SimG4CMS/Calo

@civanch, @Dr15Jones, @lveldere, @ianna, @mdhildreth, @cmsbuild, @ssekmen, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm, @ghellwig, @makortel this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11150/console

[cmsbuild]

-1
Tested at: 696ffc9
I found an error when building:

--- Registered EDM Plugin: testCaloSimHits
>> Building shared library tmp/slc6_amd64_gcc493/src/CalibCalorimetry/CaloTPG/src/CalibCalorimetryCaloTPG/libCalibCalorimetryCaloTPG.so
>> Building shared library tmp/slc6_amd64_gcc493/src/CalibCalorimetry/HcalAlgos/src/CalibCalorimetryHcalAlgos/libCalibCalorimetryHcalAlgos.so
--- Registered EDM Plugin: SimG4CMSCaloPlugins
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-02-11-1100/external/slc6_amd64_gcc493/lib/libboost_date_time.so: file not recognized: Bad address
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc493/src/CondTools/Geometry/plugins/CondToolsGeometryPlugins/libCondToolsGeometryPlugins.so] Error 1
>> Building shared library tmp/slc6_amd64_gcc493/src/CalibCalorimetry/CastorCalib/src/CalibCalorimetryCastorCalib/libCalibCalorimetryCastorCalib.so
Leaving library rule at src/SimG4CMS/ShowerLibraryProducer/plugins
@@@@ Running edmWriteConfigs for testCaloTowerGeometryESProducer
--- Registered EDM Plugin: testCaloTowerGeometryESProducer


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13255/11150/summary.html

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11153/console

[cmsbuild]

+1
Tested at: 696ffc9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13255/11153/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13255/11153/summary.html

There are some workflows for which there are errors in the baseline:
4.22 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11198/console

[cmsbuild]

+1
Tested at: c5645e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13255/11198/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13255/11198/summary.html

[bsunanda]

@civanch @ianna @mdhildreth @ssekmen We would like to have this in 8_0_0 release and approved by tomorrow. Could you kindly to review this and have it approved

[lveldere]

+1

thanks Sunanda

[ianna]

+1

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1