making HLTConfigProvider correctly handle ignored modules #13215
Conversation
|
A new Pull Request was created by @Sam-Harper for CMSSW_8_0_X. It involves the following packages: HLTrigger/HLTcore @Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
hlt-approved
fully-signed
and removed
hlt-pending
pending-signatures
labels
|
+1 |
making HLTConfigProvider correctly handle ignored modules
HLTConfigProvider sees module names which are ignored as "-modname" rather than "modname". This means when it tries to retrieve the PSet (in which the name is "modname"), it fails and doesnt recognise that it has saveTags=True. The code is now fixed to remove the front "-" if it exists when trying to retrieve the module parameters.
A second fix is for paths which has an ignored HLTLevel1GtSeed module. Currently it things there are two L1Seed modules and as such can not calculate the pre-scale. However there is really only one active one so before pushing back to the list of active L1GTSeeds, it checks if the module is ignore by looking for the "-" in front of the module name.