Tau HLT: revised L2.5 isolation

[rmanzoni]

Move from counting-based to ΣpT based isolation.
JIRA ticket with updated configuration will follow and be referenced here.

presentation to TSG
https://indico.cern.ch/event/492285/contribution/1/6/attachments/1222254/1787558/tsg_l2p5iso_3_2_2016.pdf

[cmsbuild]

A new Pull Request was created by @rmanzoni (Riccardo Manzoni) for CMSSW_8_0_X.

It involves the following packages:

RecoTauTag/HLTProducers

@Martin-Grunewald, @perrotta, @cmsbuild, @davidlange6, @fwyzard can you please review it and eventually sign? Thanks.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[Martin-Grunewald]

-1
This would change the physics outcome. You'd need to have a (new) flag to decide which algorithm to use, with the default setting of the flag to use the old calculation.
Add the new flag to fillDescriptions with the default setting!

[rmanzoni]

ok @Martin-Grunewald will do, sorry for forgetting this

[Martin-Grunewald]

Together with your requested HLT py config update (JIRA ticket), also request to flip the flag
value in the JIRA ticket.

[fwyzard]

Hi Martin, all, we are not guaranteeing any kind of physics compatibility of the HLT in 8.0.x, so from my point of view this can go ahead without the extra parameters. .A

[Martin-Grunewald]

But we DQM and validate pre6 which may use new code with old config....

[fwyzard]

I thought this would already be late for pre6 ? If it makes it for pre6, it would be nice to also have the accompanying configuration changes. .A

[Martin-Grunewald]

pre6 is fuzzy (not there yet, some outstanding prs, but should arrive before the weekend)

[rmanzoni]

that's not completely clear to me: shall I update the PR or not?

[Martin-Grunewald]

close the 76 PR. update the 80 PR.

[perrotta]

In this particular case, the algo currently in CMSSW is

•    if (dr2 >= m_isoCone2Min && dr2 <= m_isoCone2Max) iso += 1.;
  

  and the filter rejects the event whenever iso > MaxTag = cms.double( 0. )

With the algo proposed in this PR

•    if (dr2 >= m_isoCone2Min && dr2 <= m_isoCone2Max) iso += (*tr)->pt();
  

Provided the old MaxTag remains "0." in the python config, then the result of the filter is exactly the same with either the new or the old code.

Therefore, even if the modified code is merged in CMSSW_8_0_0_pre6, the result of the filter will not change if MaxTag=0. The only difference will be for the modified config, which we will eventually merge in ConfDB following the expected jira ticket.

If @Martin-Grunewald agrees, I would keep this pull request untouched and I would try to merge it as quickly as possible.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10985/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10986/console

[cmsbuild]

+1
Tested at: 72fa5cc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13176/10986/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
72fa5cc
bc5d94b
195b670
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13176/10986/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13176/10986/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13176/10986/summary.html

[Martin-Grunewald]

OK, it is for a pre.

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[Martin-Grunewald]

@davidlange6
please also consider this for pre6.

[rmanzoni]

JIRA ticket
https://its.cern.ch/jira/browse/CMSHLT-695