-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
premixing : digi step : replace postls1 customisation functions with run2 era #13169
Conversation
A new Pull Request was created by @lveldere for CMSSW_8_0_X. It involves the following packages: Configuration/PyReleaseValidation @boudoul, @franzoni, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
shouldn't be "--era" at line 887? |
please test |
the typo reported by @fabozzi is fixed. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
premixing : digi step : replace postls1 customisation functions with run2 era
rebase of #13072
postLS1 customisation functions are no longer necessary for premixing:
Indeed, the customisation function in
takes the following actions
This is now replaced by adding the appropriate era option to the digi step in relval_steps.py
This function has actually zero effect
Tests: workflows 250200,500200 run properly.
@mdhildreth