Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

premixing : digi step : replace postls1 customisation functions with run2 era #13169

Merged
merged 2 commits into from
Feb 4, 2016
Merged

premixing : digi step : replace postls1 customisation functions with run2 era #13169

merged 2 commits into from
Feb 4, 2016

Conversation

lveldere
Copy link
Contributor

@lveldere lveldere commented Feb 3, 2016

rebase of #13072

postLS1 customisation functions are no longer necessary for premixing:
Indeed, the customisation function in

SLHCUpgradeSimulations/Configuration/python/postLS1CustomsPreMixing.py

takes the following actions

  • the deprecated customisePostLS1 function is called.
    This is now replaced by adding the appropriate era option to the digi step in relval_steps.py
  • the customisation function in Configuration/python/muonCustomsPreMixing.py is called
    This function has actually zero effect
    • line 5 is taken care of by the eras
    • line 8 and 9 are redundant (the correct settings are loaded in the premix digi step anyway)
    • line 13,14,17 and 18 have no effect on the digi step

Tests: workflows 250200,500200 run properly.

@mdhildreth

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

A new Pull Request was created by @lveldere for CMSSW_8_0_X.

It involves the following packages:

Configuration/PyReleaseValidation

@boudoul, @franzoni, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@lveldere
Copy link
Contributor Author

lveldere commented Feb 3, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10966/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

@fabozzi
Copy link
Contributor

fabozzi commented Feb 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

@davidlange6
Copy link
Contributor

@lveldere - @fabozzi makes a correct inquiry. Could you update the PR? Thanks!

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

Pull request #13169 was updated. @boudoul, @franzoni, @fabozzi, @cmsbuild, @srimanob, @hengne, @davidlange6 can you please check and sign again.

@fabozzi
Copy link
Contributor

fabozzi commented Feb 4, 2016

please test

@lveldere
Copy link
Contributor Author

lveldere commented Feb 4, 2016

the typo reported by @fabozzi is fixed.

@lveldere
Copy link
Contributor Author

lveldere commented Feb 4, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10993/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

@fabozzi
Copy link
Contributor

fabozzi commented Feb 4, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

davidlange6 added a commit that referenced this pull request Feb 4, 2016
premixing : digi step : replace postls1 customisation functions with run2 era
@davidlange6 davidlange6 merged commit 7c335d8 into cms-sw:CMSSW_8_0_X Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants