Added code to set isolated Photon puppi weight to 1 for loose id photons above 10 GeV #13157
Conversation
|
A new Pull Request was created by @violatingcp (Philip Harris) for CMSSW_8_0_X. It involves the following packages: CommonTools/PileupAlgos @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| return false; | ||
| } | ||
| // ------------------------------------------------------------------------------------------ | ||
| void PuppiPhoton::beginJob() { |
There was a problem hiding this comment.
please remove all empty methods (from cc and from the header file).
There is more maintenance burden than benefits from potential future use of these placeholders.
There was a problem hiding this comment.
I am not sure what you mean, this method is used in a number places in the code.
There was a problem hiding this comment.
Nevermind, I understand
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
-1 DAS Error you can see the results of the tests here: |
| if(!usePFRef_) continue; | ||
| try{ | ||
| const pat::Photon *pPho = dynamic_cast<const pat::Photon*>(&(*itPho)); | ||
| if(pPho != 0) { |
There was a problem hiding this comment.
nullptr instead of 0 is preferred (minor though)
|
static analysis of the previous version |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 for #13157 759396d
|
Added code to set isolated Photon puppi weight to 1 for loose id photons above 10 GeV
Code which sets the weight of Loose id Isolated photons to weight 1. This fixes puppet behavior in gamma+jets events where isolated high pT photons get weight 0. The code works by setting the weight weight of all associated pfcandidates to the designated puppiweight (1, but its configurable). This will allow for improved electron and photon isolation since an improved footprint removal can be done.
An example of the inteded use in puppet is shown in the test config.
@nhanvtran @hsatoshi