Fixes for800 #13142
Fixes for800 #13142
Conversation
|
A new Pull Request was created by @fcavallo (Francesca Romana Cavallo) for CMSSW_8_0_X. It involves the following packages: DQM/DTMonitorClient @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
| @@ -283,7 +300,7 @@ int DTOccupancyTest::runOccupancyTest(TH2F *histo, const DTChamberId& chId, | |||
| bool failCells = false; | |||
|
|
|||
| // Check that the chamber has digis | |||
| if(histo->Integral() == 0) { | |||
| if (getIntegral(histo,chId) == 0) { | |||
There was a problem hiding this comment.
probably a check on the maximum would be more efficient here.
referring to TH1::GetMaximum
https://root.cern.ch/doc/master/classTH1.html#acb53c99a65ab29a045cbdc2789e55250
the chId in the list of arguments passed to the function is not needed.
There was a problem hiding this comment.
I think you're right. Is it still in time tomorrow for the integration in 800, if I make the change and check it again?
There was a problem hiding this comment.
this is a simple fix. so yes, you are right.
thanks,
F.
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
Pull request #13142 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again. |
|
please test |
|
+1 |
cmsbuild
added
dqm-pending
pending-signatures
tests-pending
and removed
dqm-approved
fully-signed
tests-rejected
labels
|
Pull request #13142 was updated. @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please check and sign again. |
| @@ -342,7 +360,7 @@ int DTOccupancyTest::runOccupancyTest(TH2F *histo, const DTChamberId& chId, | |||
|
|
|||
| int binY = binYlow+(lay-1); | |||
|
|
|||
| double layerInteg = histo->Integral(1,nBinsX,binY,binY); | |||
| double layerInteg = getIntegral(histo,1,nBinsX,binY,binY,true); | |||
| squaredLayerOccupSum += layerInteg*layerInteg; | |||
| totalChamberOccupp+= layerInteg; | |||
There was a problem hiding this comment.
squaredLayerOccupSum and totalChamberOccupp are apparently not used.
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
+1 |
bug fix in occupancy summary