bsunanda:Run2-hcx64 Introduce changes needed for Hcal geometry for 2016 and 2017

[bsunanda]

This takes care of additional channels for HF, additional trigger primitives for HF and new layout of HE for phase I

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_8_0_X.

It involves the following packages:

Geometry/CaloTopology
Geometry/HcalCommonData
Geometry/HcalTowerAlgo

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10863/console

[cmsbuild]

-1

Tested at: 2b64bca
I found errors in the following unit tests:

---> test runtestSimCalorimetryHGCalSimProducers had ERRORS
---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13139/10863/summary.html

[cmsbuild]

Pull request #13139 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10868/console

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13139/10863/summary.html

[cmsbuild]

-1

Tested at: 27108bd
I found errors in the following unit tests:

---> test runtestSimCalorimetryHGCalSimProducers had ERRORS
---> test testRecoMETMETProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13139/10868/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13139/10868/summary.html

[bsunanda]

I checked both these unit tests:
cmsRun $CMSSW_RELEASE_BASE/src/SimCalorimetry/HGCalSimProducers/test/testHGCalDigi_cfg.py
cmsRun $CMSSW_RELEASE_BASE/src/RecoMET/METProducers/test/recoMET_pfClusterMet_cfg.py
without and with these PR's with the current IB. The tests failed in both the scenario with similar error message. So I don't think the failure is due to this PR.

[ianna]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13139/11059/summary.html

[ianna]

@bsunanda - I assume we'll need a new set of GTs with updated records for Hcal parameters.

[mmusich]

+1
changes in CalibCalorimetry/HcalAlgos and CalibCalorimetry/HcalPlugins are OK.
Caveats:

• please let us know when new conditions for updating the Global Tag are available
• as far as we can understand proposed changes in the geometry remain un-probed in the PR tests as geometry is accessed via DB.

[bsunanda]

@ianna It is worthwhile to have one for 2016 scenario. I made the cfi file using Run I pixel and the new HCAL which will be for 2016 operation

[ianna]

@mmusich - Could you, please, create a 2016 GT queue starting from 2015 one.
BTW, there is still a problem with DropBox HcalParameters schema. All 2017 but this tag have been uploaded.

[mmusich]

@ianna please use the conditionsUpload service instead of the Dropbox. I sent you a private message about it.

[ianna]

@mmusich - thanks! I've send a request for 2017 GT update. Please, let me know when 2016 queue is there.

[mmusich]

@ianna, thanks we are integrating those in the 80X_upgrade2017_design_Queue.
for what concerns the 2016 there is no dedicated 2016 upgrade queue, since this involves the simulation of this year data-taking, therefore should go on the standard queues.

[davidlange6]

except we need also a 2015 geometry (for 2015 data) - some naming discussion is needed to get all of this right as we learn more about the requirements..

On Feb 9, 2016, at 4:06 PM, Marco Musich notifications@github.com wrote:

@ianna, thanks we are integrating those in the 80X_upgrade2017_design_Queue.
for what concerns the 2016 there is no dedicated 2016 upgrade queue, since this involves the simulation of this year data-taking, therefore should go on the standard queues.

—
Reply to this email directly or view it on GitHub.

[ianna]

@mmusich - I'm afraid, there are changes in Hcal parameters tag which is without label... We do need a new GT for that.

[mmusich]

@ianna, you mean a new queue.

[ianna]

@mmusich - yes, please.

@bsunanda - BTW, are 2016 and 2017 scenarios the two Frank was talking about (with different depth segmentation)? or we'll need one more variation?

[bsunanda]

@davidlange6 Could you please integrate this. I would like to submit a PR based on that IB and want that to be a part of 8_0_0

[kpedro88]

@davidlange6 It is really quite important for this one to be merged...

[bsunanda]

@davidlange6 Do you know when I can get the IB with this PR integrated?

---

From: Ianna Osborne [notifications@github.com]
Sent: 09 February 2016 16:15
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx64 Introduce changes needed for Hcal geometry for 2016 and 2017 (#13139)

@mmusichhttps://github.com/mmusich - yes, please.

@bsunandahttps://github.com/bsunanda - BTW, are 2016 and 2017 scenarios the two Frank was talking about (with different depth segmentation)? or we'll need one more variation?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/13139#issuecomment-181910256.

[davidlange6]

sorry for the wait, was getting a working IB...

[bsunanda]

Thanks David. Already submitted the next one

---

From: David Lange [notifications@github.com]
Sent: 11 February 2016 07:54
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx64 Introduce changes needed for Hcal geometry for 2016 and 2017 (#13139)

sorry for the wait, was getting a working IB...

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/13139#issuecomment-182739617.