Implement propagate_const in the framework #13093
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_8_0_X. It involves the following packages: DataFormats/Common @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| @@ -414,7 +417,7 @@ namespace edm { | |||
| virtual void endRun(Run&); | |||
| virtual void beginJob(); | |||
| virtual void endJob(); | |||
| virtual SharedResourcesAcquirer* resourceSharedWithDelayedReader_() const; | |||
| virtual SharedResourcesAcquirer* resourceSharedWithDelayedReader_(); | |||
|
|
|||
There was a problem hiding this comment.
OK to return ptr to non-const in const function because the SharedResourcesAcquirer is mutable.
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
-1 >> Compiling edm plugin /afs/cern.ch/cms/sw/ReleaseCandidates/jenkins-workarea/area3.10G/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-27-2300/src/GeneratorInterface/BeamHaloGenerator/src/BeamHaloProducer.cc >> Compiling edm plugin /afs/cern.ch/cms/sw/ReleaseCandidates/jenkins-workarea/area3.10G/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-27-2300/src/GeneratorInterface/BeamHaloGenerator/src/PYR.cc >> Compiling edm plugin /afs/cern.ch/cms/sw/ReleaseCandidates/jenkins-workarea/area3.10G/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-27-2300/src/GeneratorInterface/BeamHaloGenerator/src/SealModule.cc >> Compiling /afs/cern.ch/cms/sw/ReleaseCandidates/jenkins-workarea/area3.10G/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-27-2300/src/GeneratorInterface/BeamHaloGenerator/src/ki_bhg_fill.F >> Compiling /afs/cern.ch/cms/sw/ReleaseCandidates/jenkins-workarea/area3.10G/workspace/ib-any-integration/CMSSW_8_0_X_2016-01-27-2300/src/GeneratorInterface/BeamHaloGenerator/src/ki_bhg_init.F f951: fatal error: error closing /tmp/cmsbuild/cchJDXFy.s: No space left on device compilation terminated. f951: fatal error: error closing /tmp/cmsbuild/cc7eP9wy.s: No space left on device compilation terminated. Fatal Error: output filename specified twice Fatal Error: output filename specified twice you can see the results of the tests here: |
|
@cmsbuild @Dr15Jones @davidlange6 The build error has nothing to do with this PR. Your disk ran out of space. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
tests-started
and removed
tests-rejected
tests-pending
labels
|
-1 Tested at: ff8dcc2 ---> test runtestSimCalorimetryHGCalSimProducers had ERRORS you can see the results of the tests here: |
Implement propagate_const in the framework
This PR supersedes PR #13015.
This PR uses the propagate_const template for most pointers in the framework that are data members of classes or structs, and makes the knock on changes caused by this. This means that a const member function of the class will no longer be able to modify the data to which the pointer points. This PR is therefore a partial implementation of issue #12840. The member pointers in the framework that are not modified by this PR are:
Other minor changes made in a very few places in affected code:
a) a few boost::scoped_ptr changed to std::unique_ptr
b) a few std::auto_ptr changed to std::unique_ptr
c) iterator loops replaced by range based for loops
d) nullptr replaces 0 for pointers
This PR does not change any instances of boost::shared_ptr to std::shared_ptr, because most of these have already been changed in previous PR's, and the ones remaining are not trivial to change. These will be changed in subsequent PR's where feasible.