Phase2 Outer Tracker Clusterizer integration in CMSSW 8

[thomaslenzi]

This PR migrates the Phase2 Outer Tracker Clusterizer from CMSSW 6_2_SLHC to CMSSW 8. It adds the new data format for the clusters as well as the clustering algorithm itself.

[cmsbuild]

A new Pull Request was created by @thomaslenzi (Thomas Lenzi) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/Phase2TrackerCluster
RecoLocalTracker/SiPhase2Clusterizer

The following packages do not have a category, yet:

RecoLocalTracker/SiPhase2Clusterizer

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @gpetruc, @cerati, @threus this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[thomaslenzi]

I would also like to note that I have informed Daniel Elvira about the new package RecoLocalTracker/SiPhase2Clusterizer

[slava77]

we recommend to start from version 2 for new classes

[slava77]

@thomaslenzi
it will take me a bit longer to send all comments to the code, I'll post a message when I'm done

[slava77]

@cmsbuild please test
to collect other possible issues with the code

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10779/console

[cmsbuild]

Pull request #13087 was updated. @cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please check and sign again.

[thomaslenzi]

I pushed changes to my branch and hope this will solve the problems highlighted here-above.

[cmsbuild]

+1
Tested at: 8197293
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13087/10779/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13087/10779/summary.html

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10845/console

[cmsbuild]

+1
Tested at: 8628a59
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13087/10845/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13087/10845/summary.html

[slava77]

+1

for #13087 8628a59

• code changes look somewhat OK, considering the preliminary stages of integration; only new code is added
• jenkins tests pass: compilation is OK and the static analyzer shows no issues (although I'm not fully sure it checks the new packages); comparisons with baseline show no differences (more as a sanity check).

[smuzaffar]

cms-bot recheck packages

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[VinInn]

@davidlange6, what is the status of this?
moved to 810 or will be integrated in some sort of 801?

[davidlange6]

sorry, is in need of me to look - but would prefer its for 81x.

On Mar 1, 2016, at 4:38 PM, Vincenzo Innocente notifications@github.com wrote:

@davidlange6, what is the status of this?
moved to 810 or will be integrated in some sort of 801?

—
Reply to this email directly or view it on GitHub.

[boudoul]

It is in 800pre6 , isnt' it ?
https://github.com/cms-sw/cmssw/releases/CMSSW_8_0_0_pre6

[VinInn]

oh yes, sorry did not noticed that was merged on January 31!

[delaere]

Yes indeed. This one was merged. The question is valid for PR #13185 vs #13368 (the digitizer). In principle the digitizer is needed by the clusterizer, but I have no problem if we skip 80X, as we have presently no phase2tk workflow in that release cycle.

[davidlange6]

indeed, I missed clusterizer->digitizer… I need one last look at the digitizer PR and it goes for 81x (and phase2 should forget about 80x for now)

On Mar 1, 2016, at 4:58 PM, Christophe Delaere notifications@github.com wrote:

Yes indeed. This one was merged. The question is valid for PR #13185 vs #13368 (the digitizer). In principle the digitizer is needed by the clusterizer, but I have no problem if we skip 80X, as we have presently no phase2tk workflow in that release cycle.

—
Reply to this email directly or view it on GitHub.

[VinInn]

yes. And we need to proceed forward. We need the digitizer and new workflows so that tracking can plugin and proceed as well

[boudoul]

the workflow with phase2 (flat and tilted) up to gen sim just pull requested in 81X - Including the local reco steps will follow (factorizing the 2 steps to ease the integration)