-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of postLS1 customisation function for premixing #13072
Conversation
A new Pull Request was created by @lveldere for CMSSW_8_0_X. It involves the following packages: Configuration/PyReleaseValidation @civanch, @lveldere, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @ssekmen, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: ecf7a1c cmsDriver.py RelVal -s L1REPACK:GT2 --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Tue Jan 26 17:07:05 2016-date Tue Jan 26 17:06:16 2016 s - exit: 23552 you can see the results of the tests here: |
please test |
The tests are being triggered in jenkins. |
+1 |
The premixing digi step (step2 in matrix workflows) still depends on postLS1 customisation functions
(e.g. runTheMatrix -l 250200,50400). This pr gets rid of that dependence.
postLS1 customisation functions are no longer necessary for premixing:
Indeed, the customisation function in
takes the following actions
This is now replaced by adding the appropriate era option to the digi step in relval_steps.py
This function has actually zero effect
Similar for FastSim.
FastSim premixing required some additional changes.
(part of the bugfix of #13071)
Tests: workflows 250400,250200,500200 run properly.
@mdhildreth