Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of postLS1 customisation function for premixing #13072

Closed
wants to merge 1 commit into from
Closed

Get rid of postLS1 customisation function for premixing #13072

wants to merge 1 commit into from

Conversation

lveldere
Copy link
Contributor

The premixing digi step (step2 in matrix workflows) still depends on postLS1 customisation functions
(e.g. runTheMatrix -l 250200,50400). This pr gets rid of that dependence.

postLS1 customisation functions are no longer necessary for premixing:
Indeed, the customisation function in

SLHCUpgradeSimulations/Configuration/python/postLS1CustomsPreMixing.py

takes the following actions

  • the deprecated customisePostLS1 function is called.
    This is now replaced by adding the appropriate era option to the digi step in relval_steps.py
  • the customisation function in Configuration/python/muonCustomsPreMixing.py is called
    This function has actually zero effect
    • line 5 is taken care of by the eras
    • line 8 and 9 are redundant (the correct settings are loaded in the premix digi step anyway)
    • line 13,14,17 and 18 have no effect on the digi step

Similar for FastSim.
FastSim premixing required some additional changes.
(part of the bugfix of #13071)

Tests: workflows 250400,250200,500200 run properly.

@mdhildreth

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_8_0_X.

It involves the following packages:

Configuration/PyReleaseValidation
FastSimulation/Configuration

@civanch, @lveldere, @boudoul, @franzoni, @mdhildreth, @fabozzi, @cmsbuild, @ssekmen, @srimanob, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @matt-komm, @Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@lveldere
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10744/console

@cmsbuild
Copy link
Contributor

-1

Tested at: ecf7a1c
I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:GT2 --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Tue Jan 26 17:07:05 2016-date Tue Jan 26 17:06:16 2016 s - exit: 23552
cmsRun /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-01-25-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Jan 26 17:07:05 2016-date Tue Jan 26 17:06:16 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Tue Jan 26 17:07:05 2016-date Tue Jan 26 17:06:16 2016 s - exit: 21504

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13072/10744/summary.html

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

please test
(errors not related to this branch)

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10758/console

@lveldere
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants