Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr stage2unpacker 80x #13068

Merged
merged 25 commits into from
Feb 6, 2016

Conversation

mulhearn
Copy link
Contributor

This PR adds all of the L1T raw data packers and unpackers that use the L1TRawToDigi framework. It Includes the most crucial unpackers needed for the 2016 run (Calo Stage2, uGMT, and uGT). It includes also the EMTF and BMTF unpacker, which are not yet included in the standard sequence.

This PR will become smaller as #13065 is merged.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mulhearn for CMSSW_8_0_X.

It involves the following packages:

CondCore/L1TPlugins
CondFormats/DataRecord
CondFormats/L1TObjects
DataFormats/L1TGlobal
DataFormats/L1TMuon
DataFormats/L1Trigger
EventFilter/L1TRawToDigi
EventFilter/RawDataCollector
L1Trigger/L1TCalorimeter
L1Trigger/L1TGlobal
L1Trigger/L1TMuon
L1Trigger/L1TMuonBarrel

The following packages do not have a category, yet:

DataFormats/L1TMuon
L1Trigger/L1TMuon
L1Trigger/L1TMuonBarrel

@diguida, @emeschi, @cerminar, @cmsbuild, @ggovi, @franzoni, @mommsen, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn
Copy link
Contributor Author

please test

@mulhearn
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10736/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 52b6b06
When I ran the RelVals I found an error in the following worklfows:
8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13068/10736/summary.html

@cmsbuild
Copy link
Contributor

Pull request #13068 was updated. @diguida, @emeschi, @cerminar, @cmsbuild, @ggovi, @franzoni, @mommsen, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

@mulhearn
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10799/console

@mulhearn
Copy link
Contributor Author

+1

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 5, 2016

OK, there's the update.

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 5, 2016

+1

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 5, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11025/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

Pull request #13068 was updated. @cmsbuild, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

-1
Tested at: 6be1f23
I found an error when building:

>> Compiling python modules src/L1Trigger/L1TMuonEndCap/python
>> Compiling python modules src/DQMServices/Components/python
>> All python modules compiled
>> Pluging of all type refreshed.
gmake[1]: Leaving directory `/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_8_0_X_2016-02-04-2300'
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 1


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13068/11025/summary.html

@mulhearn
Copy link
Contributor Author

mulhearn commented Feb 5, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11031/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

@davidlange6 davidlange6 merged commit 6be1f23 into cms-sw:CMSSW_8_0_X Feb 6, 2016
@mulhearn mulhearn deleted the pr-stage2unpacker-80x branch February 11, 2016 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants