Pr l1tglobal emulator 80x #13066
Pr l1tglobal emulator 80x #13066
Conversation
Conflicts: L1Trigger/L1TGlobal/src/GtBoard.cc
|
A new Pull Request was created by @mulhearn for CMSSW_8_0_X. It involves the following packages: DataFormats/L1TGlobal @cmsbuild, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
l1-approved
fully-signed
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
| edm::ESHandle< TriggerMenu> l1GtMenu; | ||
| evSetup.get< L1TGlobalTriggerMenuRcd>().get(l1GtMenu) ; | ||
| m_l1GtMenu = l1GtMenu.product(); | ||
| //(const_cast<TriggerMenu*>(m_l1GtMenu))->buildGtConditionMap(); |
There was a problem hiding this comment.
@mulhearn m_l1GtMenu doesn't need to be a member data. (it is only consumed by m_algorithmMap).
But that asked, what is the cpu benefit of caching this?
There was a problem hiding this comment.
This is the CondFormat that is short-lived... soon to be replaced by the one from UTM library instead. You are asking how much we save wrt just extracting from the EventSetup during each event? I don't think we tested. What is the recommended practice (for next version)?
There was a problem hiding this comment.
recommended practice is not to cache unless it matters for performance
|
Pull request #13066 was updated. @cmsbuild, @mulhearn, @davidlange6 can you please check and sign again. |
|
Pull request #13066 was updated. @cmsbuild, @mulhearn, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 |
cmsbuild
added
l1-approved
fully-signed
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
Adds the 2016 L1 Global trigger (uGT) emulation and related data formats.