Pr l1tmuon emulator 80x #13065

mulhearn · 2016-01-26T08:06:34Z

This adds the 2016 Muon Emulation and related data formats.

The dependence on Alca/DB should clear once PR #13064 is approved.

cmsbuild · 2016-01-26T08:06:59Z

A new Pull Request was created by @mulhearn for CMSSW_8_0_X.

It involves the following packages:

CondCore/L1TPlugins
CondFormats/DataRecord
CondFormats/L1TObjects
DataFormats/L1TMuon
DataFormats/L1Trigger
L1Trigger/L1TMuon
L1Trigger/L1TMuonBarrel
L1Trigger/L1TMuonEndCap
L1Trigger/L1TMuonOverlap

The following packages do not have a category, yet:

DataFormats/L1TMuon
L1Trigger/L1TMuon
L1Trigger/L1TMuonBarrel
L1Trigger/L1TMuonEndCap
L1Trigger/L1TMuonOverlap

@diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @apfeiffer1, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

mulhearn · 2016-01-26T08:23:35Z

please test

mulhearn · 2016-01-26T08:23:41Z

+1

cmsbuild · 2016-01-26T08:24:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10732/console

cmsbuild · 2016-01-26T10:06:41Z

-1

Tested at: ab20be9
I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:GT2 --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Tue Jan 26 10:34:34 2016-date Tue Jan 26 10:33:54 2016 s - exit: 23552
cmsRun /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc6_amd64_gcc493/cms/cmssw-patch/CMSSW_8_0_X_2016-01-25-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Jan 26 10:34:34 2016-date Tue Jan 26 10:33:54 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Tue Jan 26 10:34:34 2016-date Tue Jan 26 10:33:54 2016 s - exit: 21504

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13065/10732/summary.html

cmsbuild · 2016-01-26T11:11:40Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13065/10732/summary.html

Martin-Grunewald · 2016-01-27T08:50:35Z

please test
(HIon problem should be solved)

cmsbuild · 2016-01-27T08:51:02Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10763/console

Conflicts: DataFormats/L1DTTrackFinder/interface/L1MuDTChambPhDigi.h DataFormats/L1DTTrackFinder/src/L1MuDTChambPhDigi.cc DataFormats/L1DTTrackFinder/src/classes_def.xml

cmsbuild · 2016-02-04T03:08:36Z

Pull request #13065 was updated. @cmsbuild, @mulhearn, @davidlange6 can you please check and sign again.

…dummy value in L1TMuonProducer for now.

cmsbuild · 2016-02-04T03:16:48Z

Pull request #13065 was updated. @cmsbuild, @mulhearn, @davidlange6 can you please check and sign again.

mulhearn · 2016-02-04T03:20:11Z

@davidlange6 OK, I am still learning git workflows! I was able to cherry-pick all the downstream changes just affecting muons. So I can work on this PR for cleanup purposes if necessary. I removed the header file you requested, let me know if more is needed...

mulhearn · 2016-02-04T03:20:18Z

please test

cmsbuild · 2016-02-04T03:20:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10988/console

mulhearn · 2016-02-04T03:29:28Z

+1

cmsbuild · 2016-02-04T05:56:33Z

+1
Tested at: 4eb1160
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13065/10988/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0a7650d
bcb909d
c69dfd0
bf5c902
65fd61f
bc5d94b
195b670
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13065/10988/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13065/10988/git-merge-result

cmsbuild · 2016-02-04T06:37:59Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13065/10988/summary.html

davidlange6 · 2016-02-04T09:25:27Z

@mulhearn - looks good aside from stuff going into a deprecate subdirectory. Is this run1/2015 trigger stuff or stuff never used?

mulhearn · 2016-02-04T11:09:05Z

That is stuff I really want the developers to get rid of our at least substantially clean up for v2.0. I can move it out if you like, but I prefer to keep it there as it makes easy to spot the dependent code.

mulhearn · 2016-02-04T11:12:06Z

In short, its an idiom that made sense during studies, but its code with no real hardware analog. Its sort of the complete opposite of the Calo code that has a very tight relationship between firmware and software blocks.

mulhearn · 2016-02-04T11:14:18Z

Unfortunately, due to schedule, we are essentially putting in code while cleanup is still underway. We have to do things adiabatically, because we do already have decent agreement between firmware and emulation. But my suspicion is that cleanup will be needed to reach 100% agreement and ease the long term maintenance costs.

davidlange6 · 2016-02-04T14:20:11Z

Ok, so it's not the legacy trigger. Then ok, but let's clean up asasp

Pr l1tmuon emulator 80x

cmsbuild added this to the Next CMSSW_8_0_X milestone Jan 26, 2016

cmsbuild added l1-pending alca-pending db-pending pending-signatures tests-pending orp-pending new-package-pending comparison-pending labels Jan 26, 2016

mulhearn mentioned this pull request Jan 26, 2016

Pr stage2unpacker 80x #13068

Merged

cmsbuild added l1-approved and removed l1-pending labels Jan 26, 2016

cmsbuild added tests-started and removed tests-pending labels Jan 26, 2016

mulhearn mentioned this pull request Jan 26, 2016

Tracking of PRs into CMSSW 80X cms-l1t-offline/cmssw#128

Closed

cmsbuild added tests-rejected and removed tests-started labels Jan 26, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jan 26, 2016

cmsbuild added tests-pending and removed comparison-available tests-rejected labels Jan 27, 2016

gflouris and others added 3 commits February 4, 2016 04:00

change bx range

5173c83

updates to L1T Data Formats - RegionalMuonCand

fed5c97

Conflicts: DataFormats/L1DTTrackFinder/interface/L1MuDTChambPhDigi.h DataFormats/L1DTTrackFinder/src/L1MuDTChambPhDigi.cc DataFormats/L1DTTrackFinder/src/classes_def.xml

remove unused header

0fa7a4b

thomreis added 2 commits February 4, 2016 04:12

Scheme for EMTF track address in RegionalMuonCand

e161ea1

Add uGMT input TF muon index variable to l1t::Muon data format. Fill …

4eb1160

…dummy value in L1TMuonProducer for now.

cmsbuild added tests-started and removed tests-pending labels Feb 4, 2016

cmsbuild added l1-approved and removed l1-pending labels Feb 4, 2016

cmsbuild added tests-approved and removed tests-started labels Feb 4, 2016

cmsbuild added comparison-available and removed comparison-pending labels Feb 4, 2016

davidlange6 added a commit that referenced this pull request Feb 4, 2016

Merge pull request #13065 from cms-l1t-offline/pr-l1tmuon-emulator-80x

6129747

Pr l1tmuon emulator 80x

davidlange6 merged commit 6129747 into cms-sw:CMSSW_8_0_X Feb 4, 2016

cmsbuild added a commit that referenced this pull request Feb 4, 2016

Merge pull request #13065 from cms-l1t-offline/pr-l1tmuon-emulator-80x

5329411

mulhearn deleted the pr-l1tmuon-emulator-80x branch February 11, 2016 23:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pr l1tmuon emulator 80x #13065

Pr l1tmuon emulator 80x #13065

mulhearn commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

mulhearn commented Jan 26, 2016

mulhearn commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

Martin-Grunewald commented Jan 27, 2016

cmsbuild commented Jan 27, 2016

cmsbuild commented Feb 4, 2016

cmsbuild commented Feb 4, 2016

mulhearn commented Feb 4, 2016

mulhearn commented Feb 4, 2016

cmsbuild commented Feb 4, 2016

mulhearn commented Feb 4, 2016

cmsbuild commented Feb 4, 2016

cmsbuild commented Feb 4, 2016

davidlange6 commented Feb 4, 2016

mulhearn commented Feb 4, 2016

mulhearn commented Feb 4, 2016

mulhearn commented Feb 4, 2016

davidlange6 commented Feb 4, 2016

Pr l1tmuon emulator 80x #13065

Pr l1tmuon emulator 80x #13065

Conversation

mulhearn commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

mulhearn commented Jan 26, 2016

mulhearn commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

Martin-Grunewald commented Jan 27, 2016

cmsbuild commented Jan 27, 2016

cmsbuild commented Feb 4, 2016

cmsbuild commented Feb 4, 2016

mulhearn commented Feb 4, 2016

mulhearn commented Feb 4, 2016

cmsbuild commented Feb 4, 2016

mulhearn commented Feb 4, 2016

cmsbuild commented Feb 4, 2016

cmsbuild commented Feb 4, 2016

davidlange6 commented Feb 4, 2016

mulhearn commented Feb 4, 2016

mulhearn commented Feb 4, 2016

mulhearn commented Feb 4, 2016

davidlange6 commented Feb 4, 2016