Hermetic Timing SLHC27 (fix crashes in RECO so we can use the usual workflows) #12962

lgray · 2016-01-15T14:19:51Z

The complete set of changes to the vertexing to be aware of timing.
Still needs tuning but gives an answer and does not crash.

We will need to cut a new release for this so that the timing sample DR campaign can march on.

@boudoul
@bendavid

… to be produced

…xing in the time axis.

lgray · 2016-01-15T14:20:01Z

@cmsbuild please test

cmsbuild · 2016-01-15T14:20:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10541/console

cmsbuild · 2016-01-15T14:20:11Z

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC.

It involves the following packages:

DataFormats/PatCandidates
RecoParticleFlow/FastTiming
RecoParticleFlow/PandoraTranslator
RecoVertex/AdaptiveVertexFit
RecoVertex/PrimaryVertexProducer
RecoVertex/VertexPrimitives
TrackingTools/TransientTrack

The following packages do not have a category, yet:

RecoParticleFlow/FastTiming
RecoParticleFlow/PandoraTranslator

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@mmarionncern, @imarches, @makortel, @pvmulder, @acaudron, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @bellan, @istaslis, @rovere, @cerati, @ferencek, @gpetruc, @trocino, @dgulhan, @bachtis, @battibass this is something you requested to watch as well.
@slava77, @smuzaffar, @fratnikov, @mark-grimes you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/all L2's/release manager to mark it as on hold
unhold: L1/user who put this PR on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

cmsbuild · 2016-01-15T15:40:50Z

-1

Tested at: 1383ada
I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12962/10541/summary.html

slava77 · 2016-01-15T21:05:49Z

the test fails in the IB as well

slava77 · 2016-01-15T21:14:59Z

RecoVertex/AdaptiveVertexFit/src/AdaptiveVertexFitter.cc

+        i=globalVTracks.begin(); i!=globalVTracks.end() ; ++i )
+      {
+        //std::cout << "  wgt=" << (**i).weight() << std::endl;
+      }


it's unclear if this no-op debug loops is needed

Will remove.

…otections

lgray · 2016-01-28T15:49:46Z

@slava77 Please give this a look and review. I found the issue with the crash and fixed it.
Once this is integrated into 620_SLHCX we need to cut a new release and continue the campaign.

@boudoul

cmsbuild · 2016-01-28T17:36:18Z

-1

Tested at: 5cd9e78
I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12962/10816/summary.html

lgray · 2016-01-28T22:31:02Z

As usual, unit test failures unrelated.
@slava77 If you could expedite this I would appreciate it.

slava77 · 2016-01-29T02:00:09Z

+1

for 5cd9e78

updates look ~ OK based on somewhat superficial review from the RECO perspective. More work will be needed to get this to 8X release
jenkins tests pass
local check of 12600 with customizeHGCalPandora_cff.cust_2023HGCalPandoraMuonFastTime shows a running workflow before and after the changes and new products show up

-----------------------------------------------------------------
   or, B         new, B      delta, B   delta, %   deltaJ, %    branch 
-----------------------------------------------------------------
      0.0 ->       354.0        354     NEWO   0.09     recoVertexs_offlinePrimaryVertices4D_WithBS_RECO.
      0.0 ->       318.3        318     NEWO   0.08     floatedmValueMap_ecalBarrelClusterFastTimer_PerfectResolutionModelResolution_RECO.
      0.0 ->       337.9        338     NEWO   0.08     floatedmValueMap_trackTimeValueMapProducer_generalTracksConfigurableFlatResolutionModel_RECO.
      0.0 ->       330.6        331     NEWO   0.08     floatedmValueMap_trackTimeValueMapProducer_gsfTracksConfigurableFlatResolutionModel_RECO.
      0.0 ->       573.2        573     NEWO   0.14     floatss_ecalBarrelClusterFastTimer_PerfectResolutionModel_RECO.
      0.0 ->       330.8        331     NEWO   0.08     floatedmValueMap_trackTimeValueMapProducer_gsfTracksConfigurableFlatResolutionModelResolution_RECO.
      0.0 ->       341.8        342     NEWO   0.08     recoVertexs_offlinePrimaryVertices1D__RECO.
      0.0 ->       346.1        346     NEWO   0.09     recoVertexs_offlinePrimaryVertices4D__RECO.
      0.0 ->       349.8        350     NEWO   0.09     recoVertexs_offlinePrimaryVertices1D_WithBS_RECO.
      0.0 ->       334.4        334     NEWO   0.08     floatedmValueMap_trackTimeValueMapProducer_generalTracksConfigurableFlatResolutionModelResolution_RECO.
-------------------------------------------------------------
   403744 ->      407366       3621             0.9     ALL BRANCHES

lgray · 2016-01-29T08:12:24Z

@slava77 You can merge this one into SLHCX as well, since you are release manager. I'm not sure if @davidlange6 Is responsible for merges in the SLHC releases.

davidlange6 · 2016-01-29T08:58:16Z

SLHCX is past its routine-merging shelf life. Lets discuss the basic validation for the relval and/or production at the next TP and then we’ll build a release.

On Jan 29, 2016, at 9:12 AM, Lindsey Gray notifications@github.com wrote:

@slava77 You can merge this one into SLHCX as well, since you are release manager. I'm not sure if @davidlange6 Is responsible for merges in the SLHC releases.

—
Reply to this email directly or view it on GitHub.

lgray · 2016-01-29T09:08:32Z

When in the next TP?

lgray · 2016-01-29T10:55:26Z

@davidlange6 just FYI, this PR fixes an issue with thr fast time customization thay was holding back the further processing of samples requested last year that are already processed to gen-sim.

lgray · 2016-02-01T08:12:06Z

@davidlange6 Here is some validation. I would appreciate it if we can move forward here.

Spacetime event display showing 4D and 3D vertex reconstruction (200PU).
vertex_reco_display_200PU_hgg_evt0.pdf

time resolution 50PU (because of stats)
dt_to_sim_50PU.pdf

z resolution 50PU, this is the same as the 30um expected in 3D RECO.
dz_to_sim_50PU.pdf

lgray · 2016-02-01T19:55:33Z

@davidlange6 Since there is no upgrade studies group this week. Where else should we discuss this PR and release?

lgray · 2016-02-03T13:14:13Z

@davidlange6 Ping, what shall we do here?

davidlange6 · 2016-02-04T09:33:47Z

I finally finished an email on the topic. sorry for the delay. @lgray

lgray · 2016-02-04T12:21:47Z

@makortel @VinInn Could you guys take a look and give any suggestions or some sort of "sign off". It would be useful to push this PR along. (An email is coming to you by separate post).

makortel · 2016-02-04T13:07:37Z

@lgray Looks fine to me, but you probably want to wait @VinInn.

VinInn · 2016-02-04T13:12:34Z

ok, for 80X (or 81X) it needs a bit of streamlining... (to many ifs)

lgray · 2016-02-04T13:15:53Z

@VinInn thanks. Sure, for 80X I can make it less branchy.
By the way, how long till phase 2 tracking in 80X (i.e. running work flow)?
If there is the tracking already I could already forward port this stuff.

lgray · 2016-02-08T12:34:08Z

@davidlange6 Please have a look here. Vincenzo was OK with alterations.

Hermetic Timing SLHC27 (fix crashes in RECO so we can use the usual workflows)

lgray · 2016-02-11T14:09:07Z

@boudoul Since SLHC28 is now out, who do I need to talk to in order to start the various DR steps for the pileup levels we discussed?

boudoul · 2016-02-11T14:18:19Z

hi @lgray I'll send a mail to the relevant parties this afternoon

lgray · 2016-02-11T14:25:55Z

@boudoul thanks a lot!

On Thu, Feb 11, 2016 at 3:18 PM, boudoul notifications@github.com wrote:

hi @lgray https://github.com/lgray I'll send a mail to the relevant
parties this afternoon

—
Reply to this email directly or view it on GitHub
#12962 (comment).

lgray · 2016-02-11T14:47:42Z

@boudoul Just to remind the PU values we agreed upon : 20, 50, 80, 110, 140, 200

lgray added 9 commits November 20, 2015 15:42

2D vertex clusterizer compiles

cb2229a

current error is invalid sum of weights in vertex, causes no vertices…

5b87998

… to be produced

2D annealing works

247d57c

trying to understand tracking particle simmatches

5afa35a

scales decently to 200PU, needs a bit more work to clean up the verte…

31e7613

…xing in the time axis.

30um z resolution, 8.5ps time resolution

64b8fe0

add skeleton of ECAL barrel timer

4548280

fix typo

ea1ca61

quiet all the couts

1383ada

cmsbuild added this to the Next CMSSW_6_2_X_SLHC milestone Jan 15, 2016

cmsbuild added reconstruction-pending analysis-pending pending-signatures tests-pending orp-pending new-package-pending comparison-pending labels Jan 15, 2016

cmsbuild added tests-started and removed tests-pending labels Jan 15, 2016

cmsbuild added tests-rejected and removed tests-started labels Jan 15, 2016

slava77 reviewed Jan 15, 2016
View reviewed changes

up minimum temperature and slow down cooling schedule, restore old pr…

0d25a25

…otections

cmsbuild removed the tests-rejected label Jan 16, 2016

cmsbuild added tests-started and removed tests-pending labels Jan 28, 2016

cmsbuild added tests-rejected and removed tests-started labels Jan 28, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jan 29, 2016

davidlange6 added a commit that referenced this pull request Feb 9, 2016

Merge pull request #12962 from lgray/hermetic_timing_demo_SLHC27

2c7bd6f

Hermetic Timing SLHC27 (fix crashes in RECO so we can use the usual workflows)

davidlange6 merged commit 2c7bd6f into cms-sw:CMSSW_6_2_X_SLHC Feb 9, 2016

lgray mentioned this pull request Sep 2, 2016

Vertex Reconstruction with Timing 810 #15710

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hermetic Timing SLHC27 (fix crashes in RECO so we can use the usual workflows) #12962

Hermetic Timing SLHC27 (fix crashes in RECO so we can use the usual workflows) #12962

lgray commented Jan 15, 2016

lgray commented Jan 15, 2016

cmsbuild commented Jan 15, 2016

cmsbuild commented Jan 15, 2016

cmsbuild commented Jan 15, 2016

slava77 commented Jan 15, 2016

slava77 Jan 15, 2016

lgray Jan 16, 2016

lgray commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

lgray commented Jan 28, 2016

slava77 commented Jan 29, 2016

lgray commented Jan 29, 2016

davidlange6 commented Jan 29, 2016

lgray commented Jan 29, 2016

lgray commented Jan 29, 2016

lgray commented Feb 1, 2016

lgray commented Feb 1, 2016

lgray commented Feb 3, 2016

davidlange6 commented Feb 4, 2016

lgray commented Feb 4, 2016

makortel commented Feb 4, 2016

VinInn commented Feb 4, 2016

lgray commented Feb 4, 2016

lgray commented Feb 8, 2016

lgray commented Feb 11, 2016

boudoul commented Feb 11, 2016

lgray commented Feb 11, 2016

lgray commented Feb 11, 2016

Hermetic Timing SLHC27 (fix crashes in RECO so we can use the usual workflows) #12962

Hermetic Timing SLHC27 (fix crashes in RECO so we can use the usual workflows) #12962

Conversation

lgray commented Jan 15, 2016

lgray commented Jan 15, 2016

cmsbuild commented Jan 15, 2016

cmsbuild commented Jan 15, 2016

cmsbuild commented Jan 15, 2016

slava77 commented Jan 15, 2016

slava77 Jan 15, 2016

Choose a reason for hiding this comment

lgray Jan 16, 2016

Choose a reason for hiding this comment

lgray commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

lgray commented Jan 28, 2016

slava77 commented Jan 29, 2016

lgray commented Jan 29, 2016

davidlange6 commented Jan 29, 2016

lgray commented Jan 29, 2016

lgray commented Jan 29, 2016

lgray commented Feb 1, 2016

lgray commented Feb 1, 2016

lgray commented Feb 3, 2016

davidlange6 commented Feb 4, 2016

lgray commented Feb 4, 2016

makortel commented Feb 4, 2016

VinInn commented Feb 4, 2016

lgray commented Feb 4, 2016

lgray commented Feb 8, 2016

lgray commented Feb 11, 2016

boudoul commented Feb 11, 2016

lgray commented Feb 11, 2016

lgray commented Feb 11, 2016