Backporting to 71X: adding Pythia8 Filter for genparticles HT #12800

alefisico · 2015-12-15T17:44:29Z

I want to backport this request #12516 to 71X.
Please let me know if you have any question.

cmsbuild · 2015-12-15T17:44:50Z

A new Pull Request was created by @alefisico (Alejandro Gomez Espinosa) for CMSSW_7_1_X.

It involves the following packages:

GeneratorInterface/GenFilters

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

+1|approve[d]|sign[ed]: L1/L2's to approve it
-1|reject[ed]: L1/L2's to reject it
assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
hold: L1/all L2's/release manager to mark it as on hold
unhold: L1/user who put this PR on hold
merge: L1/release managers to merge this request
[@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
[@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

covarell · 2015-12-17T12:48:01Z

+1

cmsbuild · 2015-12-17T12:48:16Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10337/console

cmsbuild · 2015-12-17T12:48:17Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2015-12-17T14:11:34Z

+1
Tested at: 063cdb1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12800/10337/summary.html

cmsbuild · 2015-12-17T15:01:34Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12800/10337/summary.html

davidsheffield · 2016-01-11T17:17:10Z

Can you merge this?

covarell · 2016-01-11T17:25:10Z

Hmmm... I believe this was already presented at the ORP on Jan 5? @davidlange6

davidsheffield · 2016-01-11T17:27:29Z

OK. I forget to check if it had been brought up in that meeting.

davidlange6 · 2016-01-18T03:52:42Z

GeneratorInterface/GenFilters/src/PythiaFilterHT.cc

+
+PythiaFilterHT::~PythiaFilterHT() {
+	std::cout << "Total number of tested events = " << theNumberOfTestedEvt << std::endl;
+	std::cout << "Total number of accepted events = " << theNumberOfSelected << std::endl;


@alefisico
Sorry for the slow review

Please remove the couts. Thanks

cmsbuild · 2016-01-18T09:57:33Z

Pull request #12800 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please check and sign again.

alefisico · 2016-01-18T09:58:24Z

I think we need them for validation, but if you think they are unnecessary and it will move this request forward, I've just removed them.

alefisico · 2016-01-25T10:47:41Z

Hi all, sorry to bother again, but is there a reason why this PR is not approved? Please let me know if I need to make any other change.

covarell · 2016-01-25T10:59:11Z

+1

cmsbuild · 2016-01-25T10:59:26Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10716/console

cmsbuild · 2016-01-25T10:59:27Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2016-01-25T12:05:50Z

+1
Tested at: 2f7d9bb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12800/10716/summary.html

cmsbuild · 2016-01-25T12:40:15Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12800/10716/summary.html

davidlange6 · 2016-02-01T19:54:24Z

+1

Backporting to 71X: adding Pythia8 Filter for genparticles HT

adding PythiaHT filter

063cdb1

cmsbuild added this to the Next CMSSW_7_1_X milestone Dec 15, 2015

cmsbuild added generators-pending pending-signatures tests-pending orp-pending comparison-pending labels Dec 15, 2015

cmsbuild added generators-approved fully-signed and removed generators-pending pending-signatures labels Dec 17, 2015

cmsbuild added tests-started and removed tests-pending labels Dec 17, 2015

cmsbuild added tests-approved and removed tests-started labels Dec 17, 2015

cmsbuild added comparison-available and removed comparison-pending labels Dec 17, 2015

davidlange6 reviewed Jan 18, 2016
View reviewed changes

removing couts

2f7d9bb

cmsbuild removed comparison-available fully-signed labels Jan 18, 2016

cmsbuild added generators-pending pending-signatures tests-pending comparison-pending and removed generators-approved tests-approved labels Jan 18, 2016

cmsbuild added generators-approved fully-signed and removed generators-pending pending-signatures labels Jan 25, 2016

cmsbuild added tests-started and removed tests-pending labels Jan 25, 2016

cmsbuild added tests-approved and removed tests-started labels Jan 25, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jan 25, 2016

cmsbuild added orp-approved and removed orp-pending labels Feb 1, 2016

cmsbuild added a commit that referenced this pull request Feb 1, 2016

Merge pull request #12800 from alefisico/CMSSW_7_1_X_PythiaHTFilterv2

f9df7fe

Backporting to 71X: adding Pythia8 Filter for genparticles HT

cmsbuild merged commit f9df7fe into cms-sw:CMSSW_7_1_X Feb 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backporting to 71X: adding Pythia8 Filter for genparticles HT #12800

Backporting to 71X: adding Pythia8 Filter for genparticles HT #12800

alefisico commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

covarell commented Dec 17, 2015

cmsbuild commented Dec 17, 2015

cmsbuild commented Dec 17, 2015

cmsbuild commented Dec 17, 2015

cmsbuild commented Dec 17, 2015

davidsheffield commented Jan 11, 2016

covarell commented Jan 11, 2016

davidsheffield commented Jan 11, 2016

davidlange6 Jan 18, 2016

cmsbuild commented Jan 18, 2016

alefisico commented Jan 18, 2016

alefisico commented Jan 25, 2016

covarell commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

davidlange6 commented Feb 1, 2016

Backporting to 71X: adding Pythia8 Filter for genparticles HT #12800

Backporting to 71X: adding Pythia8 Filter for genparticles HT #12800

Conversation

alefisico commented Dec 15, 2015

cmsbuild commented Dec 15, 2015

covarell commented Dec 17, 2015

cmsbuild commented Dec 17, 2015

cmsbuild commented Dec 17, 2015

cmsbuild commented Dec 17, 2015

cmsbuild commented Dec 17, 2015

davidsheffield commented Jan 11, 2016

covarell commented Jan 11, 2016

davidsheffield commented Jan 11, 2016

davidlange6 Jan 18, 2016

Choose a reason for hiding this comment

cmsbuild commented Jan 18, 2016

alefisico commented Jan 18, 2016

alefisico commented Jan 25, 2016

covarell commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

davidlange6 commented Feb 1, 2016