-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed checksum upload validation when compressing LHE files #12571
Fixed checksum upload validation when compressing LHE files #12571
Conversation
Script only gets the checksum of the files being added to EOS. When compressing LHE files with the previous behavior, the script added a checksum for both the original .lhe file and the compressed .lhe.xz. Therefore, it would not compare the correct checksum to the file in EOS and and always produce a warning if the compression option was used.
A new Pull Request was created by @davidsheffield (David Sheffield) for CMSSW_8_0_X. It involves the following packages: GeneratorInterface/LHEInterface @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
Fixed checksum upload validation when compressing LHE files
Port of #11088 to 8_0_X.