New FED modes handled in SiStrip unpacker

[forthommel]

The FED FE packet codes has been reorganized to leave room to new modes (e.g. VR 10bit, ZS 8bit, ...). The SiStripRawToDigiUnpacker was hence modified to match these changes.
In an attempt to restore the previous unpacking behaviour a boolean has been introduced in the siStripDigis PSet to switch between the legacy modes and the new ones (siStripDigis.LegacyUnpacker = cms.bool(False)).
For more information on the requirements and new specifications, see https://its.cern.ch/jira/browse/CMSTRACK-127

[forthommel]

This PR is the 7_6_X equivalent of 7_5_X's PR #12157

[cmsbuild]

A new Pull Request was created by @forthommel (Laurent Forthomme) for CMSSW_7_6_X.

New FED modes handled in SiStrip unpacker

It involves the following packages:

DataFormats/SiStripCommon
EventFilter/SiStripRawToDigi
RecoLocalTracker/SiStripClusterizer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @nickmccoll, @jlagram, @gpetruc, @cerati, @threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9312/console

[cmsbuild]

-1
Tested at: 2ecceb0
When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 29-Oct-2015 04:53:58 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing run: 194533 lumi: 329 event: 462448434
   [1] Running path 'reconstruction_step'
   [2] Calling event method for module CandPtrSelector/'jetsForCoreTrackingPreSplitting'
   [3] Calling produce method for unscheduled module FastjetJetProducer/'ak4CaloJetsForTrkPreSplitting'
   [4] Calling produce method for unscheduled module PrimaryVertexProducer/'firstStepPrimaryVerticesPreSplitting'
   [5] Calling produce method for unscheduled module TrackProducer/'initialStepTracksPreSplitting'
   [6] Calling produce method for unscheduled module MeasurementTrackerEventProducer/'MeasurementTrackerEventPreSplitting'
   [7] Calling produce method for unscheduled module SiStripRawToDigiModule/'siStripDigis'
Exception Message:
A std::exception was thrown.
vector::reserve
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12161/9312/summary.html

[slava77]

runTheMatrix.py -l 4.53 should be enough to reproduce the error.
if it may matter, the jenkins tests were done in CMSSW_7_6_X_2015-10-28-1100

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9354/console

[cmsbuild]

Pull request #12161 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

[cmsbuild]

+1
Tested at: b6460b0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12161/9354/summary.html

[slava77]

@cmsbuild please test
(comparisons never made it)
@smuzaffar @Degano please check if the comparison machinery is still alive.
(comparisons never made it for #12157 either)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9379/console

[forthommel]

Do you have an idea of the criticality of this warning? Should we investigate this?

[slava77]

@cmsbuild please test

these are DAS-related.
Maybe re-testing will help.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9682/console

[cmsbuild]

+1
Tested at: fb69762
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12161/9682/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12161/9682/summary.html

[slava77]

+1

for #12161 fb69762

• forward-port of changes added to 75X (included in full in 755patch1)
• code changes are the same as in the combination of New FED modes handled in SiStrip unpacker #12157 + SiStrip unpacker corrupted buffer fix #12385 (checked by forward-porting from 754 to 7_6_1)
• jenkins tests pass and comparisons with the baseline show no differences

This PR is technical with respect to the data or MC taken and centrally processed so far.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[slava77]

@smuzaffar @Degano is there a way to ask for no auto-fwd-port of this PR?

[smuzaffar]

No there is no way to do this. Auto forward port is not done for individual PRs. It is done once every hour by merging all changes from 76X in to 80X.

[davidlange6]

I am cleaning up the 76x queue aside from things for analysis workflows. I'm closing this pull request, please make sure the PR is in 80x. Thanks!