Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take out the era customisations now that L1 comes from GT (76X) #12118

Merged
merged 1 commit into from
Oct 27, 2015

Conversation

mark-grimes
Copy link

Back port of the 80X #12116 as requested.

Description from #12116 copied here for completeness:
Now that the L1 configuration comes from the Global Tag, era customisations should no longer be required. As far as I'm aware this file is not used anyway, if anyone is using it with process.load("L1TriggerConfig.L1GtConfigProducers.l1GtTriggerMenuXml_cfi") it's because they want to use their own custom menu anyway.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_6_X.

Take out the era customisations now that L1 comes from GT (76X)

It involves the following packages:

L1TriggerConfig/L1GtConfigProducers

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mulhearn
Copy link
Contributor

+1

@mulhearn
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9230/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 27, 2015
Take out the era customisations now that L1 comes from GT (76X)
@cmsbuild cmsbuild merged commit 38017d3 into cms-sw:CMSSW_7_6_X Oct 27, 2015
@mark-grimes mark-grimes deleted the takeoutXMLMenuEraChange76X branch November 16, 2015 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants