Adding label HLT for PFCalibrationRcd

[mmusich]

Summary of Changes in the GT

RunII simulation

• RunII Ideal scenario : 76X_mcRun2_design_v11 as 76X_mcRun2_design_v10 with the following changes:
  • updated Preshower pedestals as per pedestal run in low gain taken in Run2015D
  • updated Preshower Zero suppression thresholds with 6 ADC
• RunII Asymptotic scenario : 76X_mcRun2_asymptotic_v11 as 76X_mcRun2_asymptotic_v10 with the following changes:
  • updated Preshower bad channels as per Run2015D
  • updated Preshower pedestals as per pedestal run in low gain taken in Run2015D
  • updated Preshower Zero suppression thresholds with 6 ADC
• RunII Startup scenario : 76X_mcRun2_startup_v11 as 76X_mcRun2_startup_v10 with the following changes:
  • updated Preshower bad channels as per Run2015D
  • updated Preshower pedestals as per pedestal run in low gain taken in Run2015D
  • updated Preshower Zero suppression thresholds with 6 ADC
• RunII Heavy Ions scenario : 76X_mcRun2_HeavyIon_v11 as 76X_mcRun2_HeavyIon_v10 with the following changes:
  • updated Preshower bad channels as per Run2015D
  • updated Preshower pedestals as per pedestal run in low gain taken in Run2015D
  • updated Preshower Zero suppression thresholds with 6 ADC

RunI data

• RunI Offline processing : 76X_dataRun1_v10 as 76X_dataRun1_v9 with the following changes:
  • added a label for PF hadron calibration specific for HLT usage.

RunII data

• RunII Offline processing : 76X_dataRun2_v10 as 76X_dataRun2_v9 with the following changes:
  • added a label for PF hadron calibration specific for HLT usage

Upgrade

• PhaseI design scenario : 76X_upgrade2017_design_v7 as 76X_upgrade2017_design_v6 with the following changes:
  • updated Preshower bad channels as per Run2015D
  • updated Preshower pedestals as per pedestal run in low gain taken in Run2015D
  • updated Preshower Zero suppression thresholds with 6 ADC

Needed for #12100 to pass addOn tests

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_7_6_X.

Adding label HLT for PFCalibrationRcd

It involves the following packages:

Configuration/AlCa

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9233/console

[mmusich]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[diguida]

please acknowledge changes

[mmusich]

@cmsbuild please acknowledge changes

[cmsbuild]

Pull request #12114 was updated. @cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please check and sign again.

[diguida]

please test

[cmsbuild]

+1
Tested at: bee66c2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12114/9264/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12114/9264/summary.html

[davidlange6]

@slava77, @cvuosalo - this may be of interest for your checks

[davidlange6]

@mmusich @diguida - could you confirm this is the sort of change expected? (smaller on the high level objects)

https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_7_6_X_2015-10-27-2300+12114/10951/validateJR/all_OldVSNew_TTbarPUwf50202p0/all_OldVSNew_TTbarPUwf50202p0c_log10EcalRecHitsSorted_ecalPreshowerRecHit_EcalRecHitsES_RECO_obj_obj_energy.png

[mmusich]

+1

[mmusich]

Hi @davidlange6, yes it's expected there were substantial changes in the PreShower digitization conditions to allow better data/mc comparison. Let me point the Ecal DPG to the comparison as well. @emanueledimarco @shervin86

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[mmusich]

For reference Talk at AlCa Meeting Oct 26th

[davidlange6]

ok - I’ll merge once we see an Ecal DPG confirmation (even if its quite late to be introducing such macroscopic changes)

On Oct 29, 2015, at 9:45 AM, Marco Musich notifications@github.com wrote:

Hi @davidlange6, yes it's expected there were substantial changes in the PreShower digitization conditions to allow better data/mc comparison. Let me point the Ecal DPG to the comparison as well. @emanueledimarco @shervin86

—
Reply to this email directly or view it on GitHub.

[diguida]

@davidlange6 clarification on the commits:

• mmusich@3c2dbc7 is already merged as it was cherry picked by use dedicated calibrations at HLT #12100 in fwyzard@cb1273c.
• mmusich@bee66c2 has been cherry picked by Revision of snapshotTime handling in HLT and new Run2 MC GT with ES fixes #12168 diguida@662a6cc

As soon as @emanueledimarco and @shervin86 confirm this is expected behaviour, we can supersede this one and merge #12168 (as it contains also #12095 plus the fix of the snapshot time).

[emanueledimarco]

@diguida @cmkuo @shervin86 (moving a private discussion here)
I was expecting that, based on the plots shown by Fabrice earlier, the cleaning removes the
bad rechits which populated the low energy shoulder of the distribution, so the change should go in the opposite direction (increasing the energy). Isn't it?

[mmusich]

@emanueledimarco this PR is closed, please move the discussion to #12168