-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding label HLT for PFCalibrationRcd #12109
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_0_X. Adding label HLT for PFCalibrationRcd It involves the following packages: Configuration/AlCa @cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
The jenkins tests job failed, please try again. |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@mmusich - I take it that the payloads with the new labels are the same as those used by the reco? |
no they aren't. They are explicitly different upon request of TSG (that's the purpose of having the HLT label). @fwyzard |
Indeed, the tag with the "HLT" label should have the calibrations for the HLT (like for the JECs etc.) .A |
should one not then see this effect in the comparisons? |
@davidlange6 only after #12100 is merged IIUC |
Correct, #12100 makes use of the new labels. |
+1 |
Adding label HLT for PFCalibrationRcd
Summary of Changes in the GT
RunI data
RunII data
Needed for #12100 to pass
addOn
tests