Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a typo in --era specification #12065

Conversation

hengne
Copy link
Contributor

@hengne hengne commented Oct 23, 2015

fix a typo in --era specification noticed by @boudoul

@davidlange6
Copy link
Contributor

@hengne - maybe a "_" could be added to HLTDR250ns (e.g., HLTDR2_50ns) to avoid the possibility for further confusion

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hengne (Hengne Li) for CMSSW_8_0_X.

fix a typo in --era specification

It involves the following packages:

Configuration/PyReleaseValidation

@danduggan, @boudoul, @franzoni, @fabozzi, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.
This pull requests was done for a production branch and will require explicit ORP approval on friday or L1 override.

@hengne
Copy link
Contributor Author

hengne commented Oct 23, 2015

@davidlange6 i think that's a good idea. this will require to change all the workflows that using that step, which has a potential to introduce new bugs, and better be tested well before a PR to change.

@davidlange6
Copy link
Contributor

Right - it means a query replace in 3 places according to the search in git. (and fortunately a test will crash if not ok in this case)

@hengne
Copy link
Contributor Author

hengne commented Oct 23, 2015

@davidlange6 I can do this change and test carefully with the current 760pre7 regular Relval update PR that I am currently preparing. Sounds good? I hope I can have it done by today or during the weekend.

@boudoul
Copy link
Contributor

boudoul commented Oct 23, 2015

@cmsbuild , please test

@davidlange6
Copy link
Contributor

sounds good. Thanks-

On Oct 23, 2015, at 10:58 AM, Hengne Li notifications@github.com wrote:

@davidlange6 I can do this change and test carefully with the current 760pre7 regular Relval update PR that I am currently preparing. Sounds good? I hope I can have it done by today or during the weekend.


Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

@boudoul
Copy link
Contributor

boudoul commented Oct 23, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Oct 24, 2015
…0_fixEraTypo

fix a typo in --era specification
@davidlange6 davidlange6 merged commit d8f6e55 into cms-sw:CMSSW_8_0_X Oct 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants