-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a typo in --era specification #12065
fix a typo in --era specification #12065
Conversation
…15-10-22-2300_fixEraTypo
@hengne - maybe a "_" could be added to HLTDR250ns (e.g., HLTDR2_50ns) to avoid the possibility for further confusion |
A new Pull Request was created by @hengne (Hengne Li) for CMSSW_8_0_X. fix a typo in --era specification It involves the following packages: Configuration/PyReleaseValidation @danduggan, @boudoul, @franzoni, @fabozzi, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks. |
@davidlange6 i think that's a good idea. this will require to change all the workflows that using that step, which has a potential to introduce new bugs, and better be tested well before a PR to change. |
Right - it means a query replace in 3 places according to the search in git. (and fortunately a test will crash if not ok in this case) |
@davidlange6 I can do this change and test carefully with the current 760pre7 regular Relval update PR that I am currently preparing. Sounds good? I hope I can have it done by today or during the weekend. |
@cmsbuild , please test |
sounds good. Thanks-
|
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
…0_fixEraTypo fix a typo in --era specification
fix a typo in --era specification noticed by @boudoul