Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a vertex smearing configution for pp at 5 TeV, based on latest info from the LHC #12040

Merged
merged 7 commits into from
Oct 28, 2015

Conversation

mandrenguyen
Copy link
Contributor

Expected beam conditions for the pp run at 5 TeV that will take place in about 4 weeks.
The GEN-SIM production will be in the same release used for 13 TeV, so I will also add this into 71X.
I can also add this in CMSSW8, if we're no longer forward porting from 76X.
As usual, we will iterate with ppd/pdmv to get the matching reco BS in the GT.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mandrenguyen for CMSSW_7_6_X.

Adding a vertex smearing configution for pp at 5 TeV, based on latest info from the LHC

It involves the following packages:

Configuration/StandardSequences
IOMC/EventVertexGenerators

@cmsbuild, @civanch, @franzoni, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor

civanch commented Oct 22, 2015

@mandrenguyen , is "Expected" an optimal name? before "Nominal" was used for 13 TeV.

@mandrenguyen
Copy link
Contributor Author

@civanch Makes sense. Will update in a bit.

@cmsbuild
Copy link
Contributor

Pull request #12040 was updated. @cmsbuild, @civanch, @franzoni, @mdhildreth, @davidlange6 can you please check and sign again.

@civanch
Copy link
Contributor

civanch commented Oct 22, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9127/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12040/9127/summary.html

There are some workflows for which there are errors in the baseline:
4.53 step 3
25.0 step 4
1330.0 step 4
1001.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@civanch
Copy link
Contributor

civanch commented Oct 22, 2015

+1
@mandrenguyen , likely similar PRs for 7_1 and 8_0 are needed

@davidlange6
Copy link
Contributor

@mandrenguyen - do we really need to keep around the last "new" HI beamspot? (ie, can we just change it as its now seemingly obsolete)

@cmsbuild
Copy link
Contributor

Pull request #12040 was updated. @cmsbuild, @civanch, @franzoni, @mdhildreth, @davidlange6 can you please check and sign again.

@mandrenguyen
Copy link
Contributor Author

@davidlange6
We had intended to update the HI beamspot to something more realistic after it become clear the centroid wasn't really going to be at the origin, but in the end decided not to restart the GEN-SIM for that, as the real data may turn out to be different from both. If it's not hurting anyone, I would leave it around (it's not active in relval) for systematic studies. If nothing else, I can always overwrite this with the real beam parameters after we actually see the data. If it really bothers you, I can zap it, preferably as a separate PR.

@civanch
Copy link
Contributor

civanch commented Oct 28, 2015

please test
@mandrenguyen , do we still need this PR?

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9255/console

@mandrenguyen
Copy link
Contributor Author

@civanch GEN-SIM will be in 71X. Not sure we'll ever run this in 76X, but I put it in just in case.

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Oct 28, 2015
Adding a vertex smearing configution for pp at 5 TeV, based on latest info from the LHC
@davidlange6 davidlange6 merged commit 3b7662f into cms-sw:CMSSW_7_6_X Oct 28, 2015
@cmsbuild
Copy link
Contributor

@mandrenguyen mandrenguyen deleted the vtxSmearingPP5TeV76X branch May 31, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants