-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TrackingVertex->TrackingParticle links in premixing #11854
Fix TrackingVertex->TrackingParticle links in premixing #11854
Conversation
@mdhildreth The issue in 760pre6 RelVals turned indeed out to be "no TrackingParticleRefs in TrackingVertex", and this seems to fix the issue (Refs appear, I didn't compare to classical mixing). Do you agree on the fix? |
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_6_X. Fix TrackingVertex->TrackingParticle links in premixing It involves the following packages: SimGeneral/DataMixingModule @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
-1 DAS Error you can see the results of the tests here: |
please test |
The tests are being triggered in jenkins. |
The jenkins tests job failed, please try again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Fix TrackingVertex->TrackingParticle links in premixing
Validation of 760pre6 revealed that the TrackingVertex->TrackingParticle links were not working https://hypernews.cern.ch/HyperNews/CMS/get/relval/4162/15.html. This PR fixes the problem.
Tested in 760pre6 with wfs 250199+250202.0 (latter manually configured to use the output of the former for premixed pileup events). Expecting differences in all validation plots using the TrackingParticles via TrackingVertex, e.g. in primary vertex validation