-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the L1REPACK step work with the Run 2 eras #11817
Make the L1REPACK step work with the Run 2 eras #11817
Conversation
A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_6_X. Make the L1REPACK step work with the Run 2 eras It involves the following packages: Configuration/StandardSequences @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @franzoni, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 |
Make the L1REPACK step work with the Run 2 eras
This PR is mainly to make the L1REPACK step work with the Run 2 eras. In doing so I've rearranged the era configuration slightly to make it a little more modular. Files import one new cff file, all of the commands in which are conditional on the stage1L1Trigger era being active. Hence it is always safe to import whether the Stage 1 trigger is being used or not. This simplifies the higher level config files, and should hopefully make them more intuitive.
If trigger experts have suggestions of a better arrangement please feel free to comment.
I've run diffs of the config files for the following workflows, and there are no differences:
@Martin-Grunewald - Once this is merged the AddOn tests will work with eras (I've checked) and I'll reopen #11690.