Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unused SiStripMonitorMuonHLT #11814

Merged

Conversation

Dr15Jones
Copy link
Contributor

The module SiStripMonitorMuonHLT is not used in any CMSSW workflows
and needs to read data of type LazyGetter<> which is has not been
made by any modules in a long time. The LazyGetter<> class is going
away becuase it is not thread-safe.

The module SiStripMonitorMuonHLT is not used in any CMSSW workflows
and needs to read data of type LazyGetter<> which is has not been
made by any modules in a long time. The LazyGetter<> class is going
away becuase it is not thread-safe.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

removed unused SiStripMonitorMuonHLT

It involves the following packages:

DQM/HLTEvF
DQM/SiStripMonitorTrack

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Oct 15, 2015

please test

@deguio
Copy link
Contributor

deguio commented Oct 15, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8909/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Oct 16, 2015
@davidlange6 davidlange6 merged commit 3f74840 into cms-sw:CMSSW_7_6_X Oct 16, 2015
@Dr15Jones Dr15Jones deleted the removeSiStripMonitorMuonHLT branch October 19, 2015 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants