Fix statics in CastorDigiMonitor. #11813

deguio · 2015-10-15T12:09:54Z

No description provided.

deguio · 2015-10-15T12:10:00Z

please test

cmsbuild · 2015-10-15T12:11:11Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8903/console

cmsbuild · 2015-10-15T12:11:13Z

A new Pull Request was created by @deguio (Federico De Guio) for CMSSW_7_6_X.

Fix statics in CastorDigiMonitor.

It involves the following packages:

DQM/CastorMonitor

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

Dr15Jones · 2015-10-15T12:15:57Z

DQM/CastorMonitor/interface/CastorDigiMonitor.h

@@ -44,6 +44,12 @@ class CastorDigiMonitor: public CastorBaseMonitor {
  MonitorElement *hSector;
  MonitorElement* hdigisize;
 //  MonitorElement* hBunchOcc;
+
+  int TS_MAX = 10;


Looks like this can be made constexpr.

I missed it was set in the constructor. However, it could become const by setting the value before the body of the constructor.

I am not the author of this module, so I want to limit my changes to just removing static variables.

TS-MAX can not be const expression as its value is set from python-file

cmsbuild · 2015-10-15T13:41:04Z

-1
Tested at: e303b20
When I ran the RelVals I found an error in the following worklfows:
4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 15-Oct-2015 14:40:01 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing run: 194533
   [1] Running path 'dqmoffline_step'
   [2] Calling beginRun for module CastorMonitorModule/'castorOfflineMonitor'
   Additional Info:
      [a] Fatal Root Error: @SUB=TAxis::TAxis::Set
bins must be in increasing order
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 15-Oct-2015 14:49:43 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing run: 1
   [1] Running path 'dqmoffline_step'
   [2] Calling beginRun for module CastorMonitorModule/'castorOfflineMonitor'
   Additional Info:
      [a] Fatal Root Error: @SUB=TAxis::TAxis::Set
bins must be in increasing order
----- End Fatal Exception -------------------------------------------------

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 15-Oct-2015 14:54:31 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing run: 1
   [1] Running path 'dqmoffline_step'
   [2] Calling beginRun for module CastorMonitorModule/'castorOfflineMonitor'
   Additional Info:
      [a] Fatal Root Error: @SUB=TAxis::TAxis::Set
bins must be in increasing order
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 15-Oct-2015 14:57:04 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing run: 165121
   [1] Running path 'dqmoffline_step'
   [2] Calling beginRun for module CastorMonitorModule/'castorOfflineMonitor'
   Additional Info:
      [a] Fatal Root Error: @SUB=TAxis::TAxis::Set
bins must be in increasing order
----- End Fatal Exception -------------------------------------------------

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 15-Oct-2015 15:13:01 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing run: 1
   [1] Running path 'dqmoffline_step'
   [2] Calling beginRun for module CastorMonitorModule/'castorOfflineMonitor'
   Additional Info:
      [a] Fatal Root Error: @SUB=TAxis::TAxis::Set
bins must be in increasing order
----- End Fatal Exception -------------------------------------------------

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 15-Oct-2015 15:13:07 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Processing run: 1
   [1] Running path 'dqmoffline_step'
   [2] Calling beginRun for module CastorMonitorModule/'castorOfflineMonitor'
   Additional Info:
      [a] Fatal Root Error: @SUB=TAxis::TAxis::Set
bins must be in increasing order
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11813/8903/summary.html

Previously, the bug was hidden by the fact statics are initialized to zero. Moving away from static arrays exposed it.

deguio · 2015-10-20T13:50:39Z

please test

cmsbuild · 2015-10-20T13:52:16Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9064/console

cmsbuild · 2015-10-20T13:52:17Z

Pull request #11813 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

deguio · 2015-10-20T13:55:55Z

@popovvp
please review the changes in this PR. they are needed to make the code thread safe.
F.

cmsbuild · 2015-10-20T15:34:57Z

+1
Tested at: c988953
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11813/9064/summary.html

cmsbuild · 2015-10-20T16:28:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11813/9064/summary.html

popovvp · 2015-10-23T11:55:53Z

 [a] Fatal Root Error: @SUB=TAxis::TAxis::Set

bins must be in increasing order

after initializing ETower[0,1] properly (in the same way as EMTow[] and EhadTow[])
the problem will be solved (looks it is done by PR 11904)

deguio · 2015-10-23T14:20:07Z

+1

cmsbuild · 2015-10-23T14:22:25Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

Fix statics in CastorDigiMonitor.

Fix statics in CastorDigiMonitor.

e303b20

cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 15, 2015

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending comparison-pending labels Oct 15, 2015

Dr15Jones reviewed Oct 15, 2015
View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Oct 15, 2015

cmsbuild added tests-rejected and removed tests-started labels Oct 15, 2015

cmsbuild mentioned this pull request Oct 19, 2015

Fix statics in CastorDigiMonitor. #11904

Merged

Properly initialize ETower array in DQM/CastorRecHitMonitor.

c988953

Previously, the bug was hidden by the fact statics are initialized to zero. Moving away from static arrays exposed it.

cmsbuild added tests-pending and removed tests-rejected labels Oct 20, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 20, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 20, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 20, 2015

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Oct 23, 2015

davidlange6 added a commit that referenced this pull request Oct 24, 2015

Merge pull request #11813 from dmitrijus/popov_static_76x

9e1de84

Fix statics in CastorDigiMonitor.

davidlange6 merged commit 9e1de84 into cms-sw:CMSSW_7_6_X Oct 24, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix statics in CastorDigiMonitor. #11813

Fix statics in CastorDigiMonitor. #11813

deguio commented Oct 15, 2015

deguio commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

Dr15Jones Oct 15, 2015

Dr15Jones Oct 15, 2015

dmitrijus Oct 15, 2015

popovvp Oct 22, 2015

cmsbuild commented Oct 15, 2015

deguio commented Oct 20, 2015

cmsbuild commented Oct 20, 2015

cmsbuild commented Oct 20, 2015

deguio commented Oct 20, 2015

cmsbuild commented Oct 20, 2015

cmsbuild commented Oct 20, 2015

popovvp commented Oct 23, 2015

deguio commented Oct 23, 2015

cmsbuild commented Oct 23, 2015

Fix statics in CastorDigiMonitor. #11813

Fix statics in CastorDigiMonitor. #11813

Conversation

deguio commented Oct 15, 2015

deguio commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

cmsbuild commented Oct 15, 2015

Dr15Jones Oct 15, 2015

Choose a reason for hiding this comment

Dr15Jones Oct 15, 2015

Choose a reason for hiding this comment

dmitrijus Oct 15, 2015

Choose a reason for hiding this comment

popovvp Oct 22, 2015

Choose a reason for hiding this comment

cmsbuild commented Oct 15, 2015

deguio commented Oct 20, 2015

cmsbuild commented Oct 20, 2015

cmsbuild commented Oct 20, 2015

deguio commented Oct 20, 2015

cmsbuild commented Oct 20, 2015

cmsbuild commented Oct 20, 2015

popovvp commented Oct 23, 2015

deguio commented Oct 23, 2015

cmsbuild commented Oct 23, 2015