-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused HITSiStripRawToClustersRoI #11812
Removed unused HITSiStripRawToClustersRoI #11812
Conversation
HITSiStripRawToClustersRoI is not used anywhere in CMSSW and it depends on getting data in the form of an edm::LazyGetter<> but no present modules create that type. We are removing all remaining uses of edm::LazyGetter<> since that class is not thread-safe.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X. Removed unused HITSiStripRawToClustersRoI It involves the following packages: Calibration/HcalIsolatedTrackReco @cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks. |
Doing |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…sRoI Removed unused HITSiStripRawToClustersRoI
HITSiStripRawToClustersRoI is not used anywhere in CMSSW and it
depends on getting data in the form of an edm::LazyGetter<> but no
present modules create that type. We are removing all remaining
uses of edm::LazyGetter<> since that class is not thread-safe.